binutils: do not build with -static-libgcc on FreeBSD#313892
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom May 27, 2024
Merged
binutils: do not build with -static-libgcc on FreeBSD#313892Ericson2314 merged 1 commit intoNixOS:masterfrom
Ericson2314 merged 1 commit intoNixOS:masterfrom
Conversation
ofborg
bot
added
10.rebuild-darwin: 0
Ericson2314
requested changes
May 26, 2024
Member
Ericson2314
left a comment
Ericson2314
left a comment
There was a problem hiding this comment.
The description should not just be part of the PR. In this case, it can be in a code comment because it describes the current state of the code (as opposed to the change from the previous state of the code to the new state of the code).
rhelmot
force-pushed
the
freebsd-minimal3/binutils
branch
from
9b2acc6 to
14de038
Compare
Contributor
Author
|
Done. |
Ericson2314
approved these changes
May 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
part of #296581
Add FreeBSD to the list of platforms which should not add -static-libgcc to CFLAGS.
The need for this is odd. The symptom without it is that the build fails because of missing LONG_MIN, which is because configure detected that limits.h does not exist, which is a falsehood. I don't know what criteria it's using to claim this, because config.log claims the requisite check exits with status 0 after outputting a warning about unused flag -static-libgcc. Removing that flag makes it work. Why? Must be the flag, but I've never seen configure do that.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.