Skip to content

binutils: Add --undefined-version on lld 17+#314781

Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom
rhelmot:freebsd-minimal3/binutils2
May 26, 2024
Merged

binutils: Add --undefined-version on lld 17+#314781
Ericson2314 merged 1 commit intoNixOS:masterfrom
rhelmot:freebsd-minimal3/binutils2

Conversation

@rhelmot
Copy link
Contributor

@rhelmot rhelmot commented May 26, 2024

Description of changes

part of #296581

See comment. The referenced fix can be seen https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=d8e1bca7ebc357ebd9b7a338a53d2767cf0564b6.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
    • x86_64-freebsd
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 26, 2024
@Ericson2314 Ericson2314 merged commit 0e883cd into NixOS:master May 26, 2024
@Ericson2314 Ericson2314 deleted the freebsd-minimal3/binutils2 branch May 26, 2024 15:54
@Ericson2314
Copy link
Member

If you wouldn't mind, it would be good to put the https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=d8e1bca7ebc357ebd9b7a338a53d2767cf0564b6 URL in the comment, and also the parentheses are not necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants