{ed,gzip,gawk,gnugrep}: Add bash to buildInputs#314660
Merged
Ericson2314 merged 4 commits intoNixOS:stagingfrom May 27, 2024
Merged
{ed,gzip,gawk,gnugrep}: Add bash to buildInputs#314660Ericson2314 merged 4 commits intoNixOS:stagingfrom
Ericson2314 merged 4 commits intoNixOS:stagingfrom
Conversation
ofborg
bot
added
10.rebuild-darwin-stdenv
ofborg
bot
added
10.rebuild-darwin: 501+
Member
|
You are modifying four different packages kept by different people. Please, do one commit per package (no need for a new PR), so we can know what to bisect in a future bisection adventure. P.S.: why the hell so many bootstrap packages has literally no maintainers? We are forcing new contributors to be maintainers of the leaf packages they want to add, but for something literally fundamental as the system bootstrap, maintainers list is empty? |
rhelmot
force-pushed
the
freebsd-minimal3/various-shell
branch
from
bdf747e to
cb543d7
Compare
Contributor
Author
|
I've split up the commit. Do you need me to take ownership of any of these packages? |
Member
|
For now there is no need to keep maintainership of them. I will create a Nixpkgs team later this week to formalize this. |
Ericson2314
reviewed
May 26, 2024
Member
Ericson2314
left a comment
Ericson2314
left a comment
There was a problem hiding this comment.
Does it make sense to use runtimeShell for this, or must these scripts use bash in particular?
rhelmot
force-pushed
the
freebsd-minimal3/various-shell
branch
from
cb543d7 to
cd9de46
Compare
Contributor
Author
|
I didn't know about runtimeShell! I've changed it. |
AndersonTorres
approved these changes
May 26, 2024
This package distributes shell scripts in /bin. Its shebangs are always patched to a /nix/store shell, but by default, they are patched to use the stdenv's shell, which during bootstrap is build in the previous stdenv. By using runtimeShell from the current stdenv, we can shorten the FreeBSD bootstrap process significantly.
This package distributes shell scripts in /bin. Its shebangs are always patched to a /nix/store shell, but by default, they are patched to use the stdenv's shell, which during bootstrap is build in the previous stdenv. By using runtimeShell from the current stdenv, we can shorten the FreeBSD bootstrap process significantly.
This package distributes shell scripts in /bin. Its shebangs are always patched to a /nix/store shell, but by default, they are patched to use the stdenv's shell, which during bootstrap is build in the previous stdenv. By using runtimeShell from the current stdenv, we can shorten the FreeBSD bootstrap process significantly.
This package distributes shell scripts in /bin. Its shebangs are always patched to a /nix/store shell, but by default, they are patched to use the stdenv's shell, which during bootstrap is build in the previous stdenv. By using runtimeShell from the current stdenv, we can shorten the FreeBSD bootstrap process significantly.
rhelmot
force-pushed
the
freebsd-minimal3/various-shell
branch
from
cd9de46 to
125d947
Compare
AndersonTorres
approved these changes
May 27, 2024
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
part of #296581
These packages distribute shell scripts in /bin. Their shebangs are always patched to a /nix/store bash, but by default, they are patched to use the stdenv's shell, which during bootstrap is build in the previous stdenv. By using bash from the current stdenv, we can shorten the FreeBSD bootstrap process significantly.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.