cargo,rustc: 1.75.0 -> 1.76.0#289940
Conversation
Ma27
left a comment
There was a problem hiding this comment.
LGTM.
Even managed to get the VM tests for kernel with Rust building by cherry-picking ruff 0.2.2 and disabling all tests in python3.pkgs.eventlet.
drupol
left a comment
There was a problem hiding this comment.
PR LGTM, but the CI is broken, are we supposed to merge it as-is?
There's nothing we can do about OfBorg timing out a build halfway through (which is what's gone wrong with 3/4 of the OfBorg builds). For the x86_64-linux failure, I've tested it locally. Usually we test fd on x86_64-darwin before merging a Rust update, but nobody has done that yet. (And we can't do it on OfBorg because OfBorg is not capable of building LLVM for Darwin before timing out, at all, so OfBorg isn't generally usable for Darwin on staging.) |
I'm wondering, is there any trivial way to do that from an aarch64-linux mac? I have a mac from my new workplace, but I'm not very much into the ecosystem, so if that's reasonable somehow, pointers would be appreciated. |
|
Build fd on x86_64-darwin. |
|
FYI, I see relatively lots of packages failing to build with
For example, /cc the staging-next PR #292500 |
|
Uh, why the hell are things like "unused import" a hard error in nixpkgs? That might be for some strict upstream CI but not here/default. |
|
It's not. This happened because The new version of rustc is saying "oh, you're using the new standard |
Description of changes
Built:
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.