Skip to content

rust-analyzer-unwrapped: 2024-02-26 -> 2024-03-11#293307

Merged
Kranzes merged 1 commit intoNixOS:masterfrom
Kranzes:rust-analyzer
Mar 11, 2024
Merged

rust-analyzer-unwrapped: 2024-02-26 -> 2024-03-11#293307
Kranzes merged 1 commit intoNixOS:masterfrom
Kranzes:rust-analyzer

Conversation

@Kranzes
Copy link
Member

@Kranzes Kranzes commented Mar 4, 2024 •
edited
Loading

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from oxalica March 4, 2024 18:56
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 4, 2024
@Kranzes
Copy link
Member Author

Kranzes commented Mar 4, 2024

It seems this depends on #289940. Drafting for now.

@Kranzes Kranzes closed this Mar 4, 2024
@Kranzes Kranzes reopened this Mar 4, 2024
@Kranzes Kranzes marked this pull request as draft March 4, 2024 20:10
lblasc
lblasc approved these changes Mar 10, 2024
View reviewed changes
Copy link
Contributor

@lblasc lblasc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.76.0 is now on master

lblasc pushed a commit to tvbeat/nixpkgs that referenced this pull request Mar 10, 2024
@Kranzes @lblasc
rust-analyzer-unwrapped: 2024-02-26 -> 2024-03-04
0fac3bb 
Diff: rust-lang/rust-analyzer@2024-02-26...2024-03-04
(cherry picked from commit 59d6d74448caaa05e1fac3e19e74fdd6eb9fec0b)

backport: NixOS#293307
@Kranzes Kranzes marked this pull request as ready for review March 10, 2024 14:20
@Kranzes
Copy link
Member Author

Kranzes commented Mar 10, 2024

@ofborg build

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Mar 10, 2024
@Kranzes Kranzes changed the title rust-analyzer-unwrapped: 2024-02-26 -> 2024-03-04 rust-analyzer-unwrapped: 2024-02-26 -> 2024-03-11 Mar 11, 2024
@Kranzes Kranzes merged commit f5736d9 into NixOS:master Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oxalica oxalica Awaiting requested review from oxalica

1 more reviewer

@lblasc lblasc lblasc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Kranzes @lblasc @delroth