Skip to content

jujutsu: 0.14.0 -> 0.15.1#293881

Merged
thoughtpolice merged 1 commit intoNixOS:masterfrom
adamcstephens:jj/0.15
Mar 10, 2024
Merged

jujutsu: 0.14.0 -> 0.15.1#293881
thoughtpolice merged 1 commit intoNixOS:masterfrom
adamcstephens:jj/0.15

Conversation

@adamcstephens
Copy link
Contributor

@adamcstephens adamcstephens commented Mar 6, 2024

Description of changes

Diff: jj-vcs/jj@v0.14.0...v0.15.1

Changelog: https://github.com/martinvonz/jj/blob/v0.15.1/CHANGELOG.md

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested review from 0x4A6F and thoughtpolice March 6, 2024 23:42
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Mar 6, 2024
Copy link
Member

@thoughtpolice thoughtpolice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that there will (unless something changes) be an 0.15.1 release very very shortly to fix a minor issue with the https://crates.io release. So let's hold off until then. Thanks for the quick update, though!

@adamcstephens adamcstephens marked this pull request as draft March 7, 2024 01:17
@adamcstephens adamcstephens changed the title jujutsu: 0.14.0 -> 0.15.0 jujutsu: 0.14.0 -> 0.15.1 Mar 7, 2024
@adamcstephens
Copy link
Contributor Author

Bumped, but this is still blocked in requiring rust 1.76 which doesn't exist in nixpkgs yet.

error: package `jj-cli v0.15.1 (/build/source/cli)` cannot be built because it requires rustc 1.76 or newer, while the currently active rustc version is 1.75.0

@shanesveller
Copy link
Contributor

Is it accurate to say that this PR could come out of draft once https://nixpk.gs/pr-tracker.html?pr=289940 reflects that the change in #289940 has reached master?

@adamcstephens
Copy link
Contributor Author

Is it accurate to say that this PR could come out of draft once https://nixpk.gs/pr-tracker.html?pr=289940 reflects that the change in #289940 has reached master?

Indeed! I'll rebase once that hits master.

@thoughtpolice
Copy link
Member

I believe that the rustc 1.76.0 bump has hit master, so you're free to rebase.

Also, please just go ahead and squash the two commits into one; no need for the intermediate 0.15.0 build. Thanks.

@adamcstephens
Copy link
Contributor Author

Yeah, I rebased this already to get rust 1.76, but the new signing tests are failing. Even when providing the necessary dependencies, e.g. openssh, these still fail.

--- STDERR:              jj-lib::runner test_ssh_signing::ssh_signing_bad_allowed_signers ---
thread 'test_ssh_signing::ssh_signing_bad_allowed_signers' panicked at lib/tests/test_ssh_signing.rs:145:10:
called `Result::unwrap()` on an `Err` value: Backend(Io(Os { code: 2, kind: NotFound, message: "No such file or directory" }))

I can fix the test failures by turning off nextest and setting checkFlags = [ "--skip=test_ssh_signing" ]

I'm giving up trying to get this working with nextest. Through a combination of bash arrays, splitting and extra escaping, I can't seem to get the arguments to pass correctly through the nextest setup hook. Using cargoTestArgs (since these need to be before the -- in the nextest run ) we need to set -E 'not test(/test_ssh_signing/)'

@thoughtpolice If you're fine with disabling nextest, I can finish this PR. If not, then you're welcome to commit to this PR (if a committer) or I can close this and let you replace it yourself.

@thoughtpolice
Copy link
Member

Disabling nextest is fine.

@adamcstephens adamcstephens marked this pull request as ready for review March 9, 2024 23:56
@ofborg ofborg bot requested a review from thoughtpolice March 10, 2024 00:21
@thoughtpolice thoughtpolice merged commit 672879b into NixOS:master Mar 10, 2024
@adamcstephens adamcstephens deleted the jj/0.15 branch March 10, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants