installShellCompletion: add sanity check#289517
Merged
SuperSandro2000 merged 1 commit intoNixOS:stagingfrom Jun 2, 2024
Merged
installShellCompletion: add sanity check#289517SuperSandro2000 merged 1 commit intoNixOS:stagingfrom
SuperSandro2000 merged 1 commit intoNixOS:stagingfrom
Conversation
ofborg
bot
added
10.rebuild-darwin-stdenv
teto
reviewed
Feb 17, 2024
SFrijters
force-pushed
the
shell-completion-check
branch
from
98cd7f1 to
6fe9762
Compare
SFrijters
force-pushed
the
shell-completion-check
branch
from
6fe9762 to
2678ea4
Compare
SFrijters
force-pushed
the
shell-completion-check
branch
from
2678ea4 to
6b6073f
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/3976 |
SuperSandro2000
approved these changes
Jun 2, 2024
Member
SuperSandro2000
left a comment
SuperSandro2000
left a comment
There was a problem hiding this comment.
I've tested this with atuin and it works as expected.
There will be probably a handful of regressions but I think we can just fix them as they happen.
SFrijters
added a commit
to SFrijters/nixpkgs
that referenced
this pull request
Jun 2, 2024
NixOS#289517 will break cross otherwise.
This was referenced Jun 2, 2024
13 tasks
This was referenced Jul 8, 2024
Open
13 tasks
13 tasks
13 tasks
13 tasks
13 tasks
YorikSar
added a commit
to YorikSar/nixpkgs
that referenced
this pull request
Aug 20, 2024
It was running unpatched binary which was failing and thus generating empty output. After NixOS#289517 installShellCompletion errors out because of this, which lead to broken build. Move installShellCompletion call to after autoPatchelfHook in fixupPhase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
When implementing #288279 I first made a typo (i.e. calling
<($out/bin/espflash completion bash)instead of<($out/bin/espflash completions bash)) and I didn't notice it until I manually checked the generated completion files - any errors when using the<(...)syntax are apparently silently ignored.I tried to add some error handing to it but it looked a bit tricky to fix without unindended breakage. But maybe having this simple sanity check would be nice.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.