Skip to content

castor: 0.14.0 -> 0.17.1#332192

Merged
drupol merged 2 commits intoNixOS:masterfrom
piotrkwiecinski:castor-update
Aug 12, 2024
Merged

castor: 0.14.0 -> 0.17.1#332192
drupol merged 2 commits intoNixOS:masterfrom
piotrkwiecinski:castor-update

Conversation

@piotrkwiecinski
Copy link
Contributor

Description of changes

https://github.com/jolicode/castor/releases/tag/v0.15.0
https://github.com/jolicode/castor/releases/tag/v0.16.0
https://github.com/jolicode/castor/releases/tag/v0.17.0
https://github.com/jolicode/castor/releases/tag/v0.17.1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: php PHP is a general-purpose scripting language geared towards web development. label Aug 4, 2024
@piotrkwiecinski piotrkwiecinski changed the title Castor update castor: 0.14.0 -> 0.17.1 Aug 4, 2024
@ofborg ofborg bot requested a review from gaelreyrol August 4, 2024 09:37
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 4, 2024
This fixes the generation of bash completion by patching the shebang of
the castor script before the generation is excuted.
@drupol drupol merged commit 164d446 into NixOS:master Aug 12, 2024
@drupol
Copy link
Contributor

drupol commented Aug 12, 2024

@piotrkwiecinski Thanks for your patience! IIRC there's another PR that might need an update using what @jtojnar advised us here. Do you think you could fix it too there?

@piotrkwiecinski
Copy link
Contributor Author

@drupol yes. I'll pick it up later today.

@piotrkwiecinski piotrkwiecinski deleted the castor-update branch August 14, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: php PHP is a general-purpose scripting language geared towards web development. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants