Skip to content

keepassxc-go: only generate shell completions if possible#325487

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
SFrijters:keepassxc-go-completions
Jul 10, 2024
Merged

keepassxc-go: only generate shell completions if possible#325487
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
SFrijters:keepassxc-go-completions

Conversation

@SFrijters
Copy link
Member

Description of changes

Failing to generate completions is a build failure after #289517.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@SFrijters SFrijters requested a review from Janik-Haag July 8, 2024 09:38
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 8, 2024
@Janik-Haag
Copy link
Member

I quit nixpkgs #323901, so I won't do any further PR reviews

@Janik-Haag Janik-Haag removed their request for review July 8, 2024 11:00
@SFrijters SFrijters requested a review from peterablehmann July 8, 2024 11:40
Copy link
Contributor

@peterablehmann peterablehmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jul 8, 2024
@SuperSandro2000 SuperSandro2000 merged commit 468e214 into NixOS:master Jul 10, 2024
@SFrijters SFrijters deleted the keepassxc-go-completions branch July 10, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants