clever-tools: missing argument for autocomplete scripts#326039
Merged
fpletz merged 1 commit intoNixOS:masterfrom Jul 13, 2024
Merged
clever-tools: missing argument for autocomplete scripts#326039fpletz merged 1 commit intoNixOS:masterfrom
fpletz merged 1 commit intoNixOS:masterfrom
Conversation
ofborg
bot
added
11.by: package-maintainer
Member
|
Probably it didn't actually work for earlier versions, but before #289517 errors in completion generation were silently ignored. |
SFrijters
reviewed
Jul 10, 2024
florian-sanders-cc
force-pushed
the
clever-tools-fix
branch
from
caa9a06 to
3634495
Compare
florian-sanders-cc
force-pushed
the
clever-tools-fix
branch
from
3634495 to
293fbeb
Compare
Contributor
Author
|
Thanks for you feedback & explanation, everything should be fixed! 😎 |
florian-sanders-cc
force-pushed
the
clever-tools-fix
branch
from
293fbeb to
99bdaf2
Compare
fpletz
approved these changes
Jul 13, 2024
fpletz
changed the title
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes #326030
Currently, the
clever-toolspackage fails to build because the completion scripts need the path of the binary as an argument but it is not provided.I don't really understand why it worked for previous versions because it should not ever have worked.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.