Mark go packages which vendor directory can't be recreated broken#245159
Closed
SuperSandro2000 wants to merge 3 commits intoNixOS:masterfrom
Closed
Mark go packages which vendor directory can't be recreated broken#245159SuperSandro2000 wants to merge 3 commits intoNixOS:masterfrom
SuperSandro2000 wants to merge 3 commits intoNixOS:masterfrom
Conversation
12 tasks
SuperSandro2000
changed the title
SuperSandro2000
force-pushed
the
go-vendor-maintenance
branch
from
5b87a6b to
f9a39d1
Compare
ofborg
bot
added
10.rebuild-darwin: 0
kirillrdy
reviewed
Jul 24, 2023
| license = licenses.bsd3; | ||
| maintainers = with maintainers; [ Madouura muscaln ]; | ||
| # vendor can't be recreated and fails with: | ||
| # error: illegal path references in fixed-output derivation '/nix/store/......-tinygo-0.26.0-go-modules.drv' |
Member
There was a problem hiding this comment.
@SuperSandro2000 can you explain how you got this error ?
I recently tried updating tinygo and I kept getting vendor hash mismatch, so maybe its related
Member
Author
There was a problem hiding this comment.
just run the following nix-build -A tinygo.go-modules --check
Member
There was a problem hiding this comment.
@SuperSandro2000 thanks for your hint, helped me to track down the problem #245445
SuperSandro2000
commented
Jul 24, 2023
| description = "Go compiler for small places"; | ||
| license = licenses.bsd3; | ||
| maintainers = with maintainers; [ Madouura muscaln ]; | ||
| # vendor can't be recreated and fails with: |
Member
Author
There was a problem hiding this comment.
Suggested change
| # vendor can't be recreated and fails with: | |
| # vendor can't be recreated by running `nix-build -A tinygo.go-modules --check` and fails with: |
This was referenced Jul 25, 2023
12 tasks
Member
|
@SuperSandro2000 I've created PRs that should resolve reproducible vendor for those packages |
Member
Author
|
now we only need to remember to close this one, if they are all merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
I don't really want to merge this as is but I hope I can get some attention by the maintainers to help fix the issues in these packages.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)