Skip to content

Mark go packages which vendor directory can't be recreated broken #245159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SuperSandro2000 wants to merge 3 commits into from
Closed

Mark go packages which vendor directory can't be recreated broken #245159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c85b3a0
kuma-cp: mark broken because vendor isn't recreateable
SuperSandro2000 Jul 24, 2023
16f6c81
tinygo: mark broken because vendor isn't recreateable
SuperSandro2000 Jul 24, 2023
f9a39d1
k2tf: mark broken because vendor isn't recreateable
SuperSandro2000 Jul 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkgs/applications/networking/cluster/kuma/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,5 +61,6 @@ buildGoModule rec {
homepage = "https://kuma.io/";
license = licenses.asl20;
maintainers = with maintainers; [ zbioe ];
broken = true; # vendor isn't reproducible with go > 1.20: nix-build -A kuma-cp.go-modules --check
};
}
3 changes: 3 additions & 0 deletions pkgs/development/compilers/tinygo/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,5 +161,8 @@ buildGoModule rec {
description = "Go compiler for small places";
license = licenses.bsd3;
maintainers = with maintainers; [ Madouura muscaln ];
# vendor can't be recreated and fails with:
Copy link
Member Author

@SuperSandro2000 SuperSandro2000 Jul 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# vendor can't be recreated and fails with:
# vendor can't be recreated by running `nix-build -A tinygo.go-modules --check` and fails with:

# error: illegal path references in fixed-output derivation '/nix/store/......-tinygo-0.26.0-go-modules.drv'
Copy link
Member

@kirillrdy kirillrdy Jul 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SuperSandro2000 can you explain how you got this error ?

I recently tried updating tinygo and I kept getting vendor hash mismatch, so maybe its related

Copy link
Member Author

@SuperSandro2000 SuperSandro2000 Jul 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just run the following nix-build -A tinygo.go-modules --check

Copy link
Member

@kirillrdy kirillrdy Jul 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SuperSandro2000 thanks for your hint, helped me to track down the problem #245445

broken = true;
};
}
1 change: 1 addition & 0 deletions pkgs/development/tools/misc/k2tf/default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,6 @@ buildGoModule rec {
homepage = "https://github.com/sl1pm4t/k2tf";
license = licenses.mpl20;
maintainers = [ maintainers.flokli ];
broken = true; # vendor isn't reproducible with go > 1.20: nix-build -A k2tf.go-modules --check
};
}