Skip to content

tinygo: fix reproducible vendor#245445

Merged
Janik-Haag merged 1 commit intoNixOS:masterfrom
kirillrdy:tinygo
Aug 20, 2023
Merged

tinygo: fix reproducible vendor#245445
Janik-Haag merged 1 commit intoNixOS:masterfrom
kirillrdy:tinygo

Conversation

@kirillrdy
Copy link
Member

@kirillrdy kirillrdy commented Jul 25, 2023

Description of changes

this is in relation to #245159

it looks like modifying (writing to ) $out in postPatch causes vendor hash to change

I've only tested using building wasm binaries

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from Madouura and muscaln July 25, 2023 21:52
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jul 25, 2023
@kirillrdy
Copy link
Member Author

investigating build failure on darwin

@kirillrdy kirillrdy marked this pull request as draft July 25, 2023 23:36
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/tinygo-help-fixing-build-on-darwin/30945/1

@kirillrdy kirillrdy force-pushed the tinygo branch 3 times, most recently from 32e4613 to bc72c8d Compare July 30, 2023 06:00
@kirillrdy kirillrdy marked this pull request as ready for review July 30, 2023 07:34
@kirillrdy
Copy link
Member Author

@Janik-Haag can you have a look a this?

@Janik-Haag
Copy link
Member

Result of nixpkgs-review pr 245445 run on x86_64-linux 1

1 package built:
  • tinygo

Copy link
Member

@Janik-Haag Janik-Haag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Janik-Haag Janik-Haag merged commit d2d2ede into NixOS:master Aug 20, 2023
@kirillrdy kirillrdy deleted the tinygo branch September 23, 2023 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants