Skip to content

kuma,kuma-cp,kuma-dp,kuma-experimental,kumactl: 1.8.1 → 2.3.1#246651

Merged
marsam merged 1 commit intoNixOS:masterfrom
kirillrdy:kuma2
Aug 26, 2023
Merged

kuma,kuma-cp,kuma-dp,kuma-experimental,kumactl: 1.8.1 → 2.3.1#246651
marsam merged 1 commit intoNixOS:masterfrom
kirillrdy:kuma2

Conversation

@kirillrdy
Copy link
Member

@kirillrdy kirillrdy commented Aug 1, 2023

Description of changes

https://github.com/kumahq/kuma/blob/master/CHANGELOG.md
kumahq/kuma@1.8.1...2.3.1

also fixes #245159

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 1, 2023
@kirillrdy
Copy link
Member Author

@Janik-Haag this is the last one 🙏 after that we can close #245159

@Janik-Haag
Copy link
Member

Result of nixpkgs-review pr 246651 run on x86_64-linux 1

5 packages built:
  • kuma
  • kuma-cp
  • kuma-dp
  • kuma-experimental
  • kumactl

Copy link
Member

@Janik-Haag Janik-Haag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Janik-Haag
Copy link
Member

Seems like you have to disable the tests if the build environment is darwin since it throws some errors about dns. After that it should be good to merge.

@kirillrdy
Copy link
Member Author

@Janik-Haag build failure on darwin is happening in dependency

will try to fix it here #250749

@marsam marsam merged commit 7b2d91f into NixOS:master Aug 26, 2023
@kirillrdy kirillrdy deleted the kuma2 branch August 26, 2023 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants