Conversation
The updated Darwin stdenv uses `llvm-strip`, but that causes issues for rav1e when using NASM and linking it with the cctools ld64. Stripping the debug information instead of everything fixes the problem.
Without the change `llvm` build fails on `gcc-13` fails as:
[ 0%] Building CXX object lib/Support/CMakeFiles/LLVMSupport.dir/Signals.cpp.o
In file included from llvm/lib/Support/Signals.cpp:14:
llvm/include/llvm/Support/Signals.h:119:8: error: variable or field 'CleanupOnSignal' declared void
119 | void CleanupOnSignal(uintptr_t Context);
| ^~~~~~~~~~~~~~~
gst-plugins-bad is used by a lot of packages, and opencv has `enableCuda` option. Forcing people to only use opencv when necessary reduces rebuild size when `config.cudaSupport = true`
gnu-efi> /build/gnu-efi-3.0.17//lib/console.c:84:68: error: passing argument 2 of ‘ConOut->OutputString’ from incompatible pointer type [8;;h ttps://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wincompatible-pointer-types-Werror=incompatible-pointer-types8;;] gnu-efi> 84 | uefi_call_wrapper(ConOut->OutputString, 2, ConOut, L"\b \b"); gnu-efi> | ^~~~~~~~ gnu-efi> | | gnu-efi> | short unsigned int *
The current version of the derivation builds in shared libraries mode, but then the "shared" flag is not passed to the "make install" invocation. This causes "make install" to perform a whole second build from scratch, in static mode, and install this to $out instead. Instead pass shared=yes as part of the makeFlags -- this is basically the only thing that the "shared" build target does anyway, and I don't think there is a similar target for "make install". This issue was detected because the .pc shipped with mupdf doesn't work with the static libraries currently shipped (it doesn't include recursive dependencies like zlib).
This can result in swift-corefoundation being included even when a derivation uses `apple_sdk_11_0.stdenv` directly, which may result in hard to debug compiler errors (unless you just happen to know cryptic compiler errors means the 10.12 and 11.0 SDKs have been mixed).
When `--add-flags` is not used, `flagsBefore` is unset. This causes an error when invoking `makeWrapper` from a context that sets `-o nounset`, as is done in `buildDotnetModule`. This change makes `makeWrapper` safe for use in these conditions.
Many dependents only require getent and not all the locale generation tools that are included in the `bin` output. This can save some closure size!
apple_sdk_11_0.stdenv: replace extraBuildInputs with CF from 11.0 SDK
mupdf: actually build and install the shared libraries version
Some of the headers are symlinked to the root `include` in upstream Libsystem, so also symlink them there from `include/pthread`.
[staging-next] Vulkan 1.3.254 (mostly)
[staging-next] mesa: 23.1.2 -> 23.1.3
I don't understand this, and it didn't seem anyone was willing to look into the issue. https://hydra.nixos.org/build/225312469/nixlog/1/tail
The build broke probably after cmake upgrade in b8ac5b6, but either way - this forcing of old C++ standard seemed bad. https://hydra.nixos.org/build/225241222/nixlog/2/tail
Member
Author
|
Not blockers for merging:
|
...into staging-next
This reverts commit 3d4769a. This broke many packages; let's revert until that's resolved. #237199 (comment)
Until PR #236458 it was doing auto-detection (!) which chose "root" (at least sometimes): https://hydra.nixos.org/log/wbxd753q70plgxjm3xdljky9a81692kk-cockpit-287.drv Now it failed due to missing getent: https://hydra.nixos.org/build/225207182/nixlog/2/tail
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helpful links
https://hydra.nixos.org/job/nixpkgs/staging-next/unstable#tabs-constituents
https://hydra.nixos.org/job/nixos/staging-next-small/tested
https://hydra.nixos.org/jobset/nixpkgs/staging-next
https://hydra.nixos.org/jobset/nixos/staging-next-small
Mass breakages
(will be edited based on progress)