Skip to content

Comments

cpeditor: fixup build#240037

Merged
vcunat merged 1 commit intoNixOS:masterfrom
wineee:cpeditor
Jun 27, 2023
Merged

cpeditor: fixup build#240037
vcunat merged 1 commit intoNixOS:masterfrom
wineee:cpeditor

Conversation

@wineee
Copy link
Member

@wineee wineee commented Jun 27, 2023

A temporary solution to fixup build

cpeditor require c++14, the setting of CMAKE_CXX_STANDARD does not seem to affect submodules since #239304

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

cpeditor require c++14, the setting of CMAKE_CXX_STANDARD does not seem to affect submodules
@wineee
Copy link
Member Author

wineee commented Jun 27, 2023

@ofborg build cpeditor

@wineee wineee requested a review from vcunat June 27, 2023 02:58
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jun 27, 2023
@vcunat vcunat merged commit e426af5 into NixOS:master Jun 27, 2023
@vcunat
Copy link
Member

vcunat commented Jun 27, 2023

Looks good and you're the sole meta.maintainers, so let's not even wait for other reactions.

@wineee wineee deleted the cpeditor branch June 27, 2023 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants