[staging-next] gst_all_1.gst-plugins-rs: add temporary fix for cargo-c test issue#239681
Conversation
tjni
left a comment
There was a problem hiding this comment.
Thank you so much for tracking this down!
There was a problem hiding this comment.
Patching Inline like this has a chance to miss other usages of the package which wouldn't be ideal.
There was a problem hiding this comment.
Like other usages within nixpkgs or other usages within the same derivation?
If you have a suggestion, I don't particularly mind changing how this is done if the result is the same
There was a problem hiding this comment.
other usages within the same derivation?
that one mostly.
I think this could either be moved into a let in where you probably want to rename it to cargo-c' or in callPackage. I think we would want to do the first here.
There was a problem hiding this comment.
I pushed an update to move cargo-c' into the let ... in in the derivation (derivation hash didn't change, so it should be functionally the same)
9582fec to
42e6f4c
Compare
Description of changes
Yay, gst-plugins-rs broke for two staging cycles in a row now...
Tests fail to run due to upstream cargo-c issue after the bump in #236611, so this makes a temporary fix to allow it to still build for now while upstream comes up with a more permanent solution I suppose
Given this new behavior for cargo-c seems to be intentional and gst-plugins-rs is not testing with this cargo-c version yet upstream (and would require non-negligible amounts of reworking for this problem), I opted to just inline a patched cargo-c instead of trying to untangle the cargo_wrapper mess in gst-plugins-rs enough to fix it there (Meson cargo workspace support when...)
Related: lu-zero/cargo-c#323 lu-zero/cargo-c#138
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)