glibc: split getent into its own output#236458
Merged
Ma27 merged 1 commit intoNixOS:stagingfrom Jun 13, 2023
Merged
Conversation
ofborg
bot
added
the
10.rebuild-linux-stdenv
ofborg
bot
added
10.rebuild-darwin: 11-100
cole-h
reviewed
Jun 7, 2023
Ma27
approved these changes
Jun 9, 2023
Member
Ma27
left a comment
Ma27
left a comment
There was a problem hiding this comment.
Code-wise LGTM.
It would be reasonable though to mention this in the release-notes before merging.
lheckemann
force-pushed
the
glibc-getent-split
branch
from
f62c1c0 to
0866d3f
Compare
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
the
2.status: merge conflict
cole-h
approved these changes
Jun 9, 2023
Member
cole-h
left a comment
cole-h
left a comment
There was a problem hiding this comment.
Seems fine after the merge conflict is addressed ;)
Many dependents only require getent and not all the locale generation tools that are included in the `bin` output. This can save some closure size!
lheckemann
force-pushed
the
glibc-getent-split
branch
from
0866d3f to
4d649f2
Compare
ofborg
bot
removed
the
2.status: merge conflict
Ma27
approved these changes
Jun 13, 2023
vcunat
added a commit
that referenced
this pull request
Jun 26, 2023
vcunat
added a commit
that referenced
this pull request
Jun 26, 2023
Until PR #236458 it was doing auto-detection (!) which chose "root" (at least sometimes): https://hydra.nixos.org/log/wbxd753q70plgxjm3xdljky9a81692kk-cockpit-287.drv Now it failed due to missing getent: https://hydra.nixos.org/build/225207182/nixlog/2/tail
mccurdyc
pushed a commit
to mccurdyc/nixpkgs
that referenced
this pull request
Jul 3, 2023
mccurdyc
pushed a commit
to mccurdyc/nixpkgs
that referenced
this pull request
Jul 3, 2023
Until PR NixOS#236458 it was doing auto-detection (!) which chose "root" (at least sometimes): https://hydra.nixos.org/log/wbxd753q70plgxjm3xdljky9a81692kk-cockpit-287.drv Now it failed due to missing getent: https://hydra.nixos.org/build/225207182/nixlog/2/tail
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Many dependents only require getent and not all the locale generation tools that are included in the
binoutput. This can save some closure size!Things done
sandbox = trueset innix.conf? (See Nix manual)nixos/tests/login.nixnix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)