Skip to content

Comments

staging-next 2023-06-02#235556

Merged
vcunat merged 212 commits intomasterfrom
staging-next
Jun 5, 2023
Merged

staging-next 2023-06-02#235556
vcunat merged 212 commits intomasterfrom
staging-next

Conversation

@vcunat
Copy link
Member

@vcunat vcunat commented Jun 2, 2023

dasJ and others added 30 commits May 1, 2023 11:13
The changes are mostly minor; numerous bugs have been fixed and a few
new command-line options have been added.

Changelog: https://lists.gnu.org/archive/html/coreutils-announce/2023-03/msg00000.html
was probably broken by recent-ish stdenv work
sord: extract "dev", "doc", "man" outputs
libcap_ng: extract dev, man outputs
This was fixed in 248401cb2c46 ("ice: avoid bonding causing auxiliary
plug/unplug under RTNL lock"), which was backported to all relevant kernels.
 nixos/no-x-libs: add gst-plugins-bad, gst-plugins-rs
vcunat and others added 5 commits June 4, 2023 20:57
I don't know why it started now, but it only happens in tests,
and generally -Werror is more suitable for upstreams than downstreams.
Otherwise it often takes 1-2 hours on Hydra, which seems unnecessary.
This reverts commit add8dd8.
This attribute doesn't belong into meta and has no effect there.
@vcunat vcunat requested a review from RaitoBezarius as a code owner June 5, 2023 04:12
vcunat and others added 3 commits June 5, 2023 06:30
This reverts commit c8d485b, reversing
changes made to 4a640f8.

llvm_16 won't even apply patches successfully, so backing out for now.
@vcunat vcunat mentioned this pull request Jun 5, 2023
12 tasks
@vcunat
Copy link
Member Author

vcunat commented Jun 5, 2023

Notable but not really a mass failure:

  • po4a regressed in some tests on *-darwin: https://hydra.nixos.org/build/222552892
    (a few retries, also locally)
    I tried to update it, but then it wouldn't pass tests on x86_64-linux. Review estimates 81 builds depending on this. (no meta.maintainers)

wegank and others added 8 commits June 5, 2023 10:55
python310Packages.imageio: unbreak on darwin
python310Packages.pyopengl: unbreak on darwin
This reverts commit 8392a8b.
It's needed for emscripten revert; see the next commit.
This reverts commit 39d2924.
Now it will at least fetch sources FIXME correctly and build on *-linux.
@vcunat vcunat merged commit 09720cc into master Jun 5, 2023
@spikespaz
Copy link
Contributor

Where should I be reporting build failures? It seems that the following are broken:

/nix/store/dmqqm6x6g1nj58cw5sl63qkdhjmisspw-glew-x86_64-unknown-linux-gnu-1.10.0.drv
/nix/store/r4pnyfmy1qf0lnqk7k54rdnwfrz7sf4q-SDL_ttf-x86_64-unknown-linux-gnu-2.0.11.drv
/nix/store/m0wz8dn1145l8cgds2fl78z5ymqsq9bi-libIDL-x86_64-unknown-linux-gnu-0.8.14.drv
/nix/store/qc5mjr2i0lmzd6rbl0sk85gfkrx59x2q-libgdiplus-x86_64-unknown-linux-gnu-6.0.5.drv
/nix/store/sz7a6fi9lbvnrhczs5m5x39vh9f7mchf-timidity-x86_64-unknown-linux-gnu-2.15.0.drv
/nix/store/nkjs8jjdf4iw42immjq23sz1bdf21yyf-rustfmt-nightly-x86_64-unknown-linux-gnu-1.69.0.drv

I would also like to see if the above derivations (exact same hashes) also fail on Hydra.

@vcunat
Copy link
Member Author

vcunat commented Jun 7, 2023

I don't know; cross-compilations aren't top-tier targets for us, especially packages that aren't very significant (basic build toolchain). Some stuff gets built on https://hydra.nixos.org/jobset/nixpkgs/cross-trunk but it's only catching up to this merge now and I don't think your packages are there.

Generally, if you find particular pull request that broke something, it's good to at least mention on it or link. (I mean, almost all commits in staging-next* PRs were originally merged in some small PR.) Otherwise... opening issues is an option, a cross-compilation label exists, also chat, but I don't deal with cross stuff normally so perhaps someone else can advise better.

For reading hydra logs for particular derivations, be it failing or succeeding, I'd recommend nix log -f. bash (example).

@spikespaz
Copy link
Contributor

spikespaz commented Jun 7, 2023

These are not or should not be cross-compiling, as the build, host, and target platforms are all the same. Nixpkgs is imported with localSystem and crossSystem, but as far as I can tell that shouldn't change any behavior because the default value for crossSystem is localSystem: https://github.com/NixOS/nixpkgs/blob/nixos-unstable/pkgs/top-level/default.nix#L22-L25

I will note that I use a very thin wrapper around nixpkgs.lib.nixosSystem and import nixpkgs.
https://github.com/spikespaz/dotfiles/blob/8859b869bd6370e172ecf5e64b08d0057fb96237/lib/builders.nix#L79
https://github.com/spikespaz/dotfiles/blob/8859b869bd6370e172ecf5e64b08d0057fb96237/hosts/default.nix

@vcunat
Copy link
Member Author

vcunat commented Jun 7, 2023

The x86_64-unknown-linux-gnu suffixes are certainly suspicious. Normal non-cross builds do not have them.

@spikespaz
Copy link
Contributor

Indeed, it is suspicious. Is it possible that whatever mechanism bypasses impure.nix also specifies null for crossPlatform, causing whatever this is (what is that?) to do a thing?

I haven't bothered to investigate further because it was my understanding that cross-compiling for the same hostPlatform and buildPlatform should be identical to not cross-compiling at all. I was under the impression that this is important to Nixpkgs. Am I mistaken?

@vcunat
Copy link
Member Author

vcunat commented Jun 7, 2023

I don't know such details around cross, I'm afraid. EDIT: but changing the name would certainly cause a rebuild even by itself.

@spikespaz
Copy link
Contributor

Who would I ping to help me investigate this?

@vcunat
Copy link
Member Author

vcunat commented Jun 7, 2023

Say, the chat I linked above: https://matrix.to/#/#cross-compiling:nixos.org

EDIT: I suppose you know about docs at https://nixos.org/manual/nixpkgs/unstable/#chap-cross

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) 6.topic: golang Go is a high-level general purpose programming language that is statically typed and compiled. 6.topic: kernel The Linux kernel 6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: printing Drivers, CUPS & Co. 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: qt/kde Object-oriented framework for GUI creation 6.topic: stdenv Standard environment 6.topic: systemd Software suite that provides an array of system components for Linux operating systems. 8.has: clean-up This PR removes packages or removes other cruft 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild on Darwin and must target a staging branch. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 10.rebuild-linux-stdenv This PR causes stdenv to rebuild on Linux and must target a staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.