handbrake: fix build

[thiagokokada]

Description of changes

There were 2 issues in the current handbrake derivation:

• Since version 1.6.0 upstream is using ffmpeg 5.1.2 instead of 5.1.1
• One of the ffmpeg patches from upstream are not applying anymore at least since 5.1.1

This commit fixes those 2 issues and allow handbrake to build again.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[thiagokokada]

@ofborg test handbrake

[drupol]

The package is set as broken, shouldn't that flag be removed now?

[thiagokokada]

The package is set as broken, shouldn't that flag be removed now?

It is only marked as broken Darwin, which I assume is still broken. The issue I am fixing is for Linux systems.

[vcunat]

Well, this is short-lived, as we're about to merge staging-next #235556 which has ffmpeg-5.1.3, making handbrake fail again.

EDIT log: https://hydra.nixos.org/build/222801596/nixlog/3/tail

[thiagokokada]

Well, this is short-lived, as we're about to merge staging-next #235556 which has ffmpeg-5.1.3, making handbrake fail again.

EDIT log: https://hydra.nixos.org/build/222801596/nixlog/3/tail

This is strange, the derivation pins the ffmpeg version so it shouldn't matter if the derivation for ffmpeg_5 itself is bumped.

Edit: unless the ffmpeg_5 derivation includes the same patches as this patched version.