Skip to content

Comments

alacritty: unbreak on darwin#236052

Merged
wegank merged 1 commit intoNixOS:staging-nextfrom
wegank:alacritty-darwin
Jun 5, 2023
Merged

alacritty: unbreak on darwin#236052
wegank merged 1 commit intoNixOS:staging-nextfrom
wegank:alacritty-darwin

Conversation

@wegank
Copy link
Member

@wegank wegank commented Jun 5, 2023

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jun 5, 2023
@ofborg ofborg bot requested review from Br1ght0ne and Mic92 June 5, 2023 09:56
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jun 5, 2023
@wegank
Copy link
Member Author

wegank commented Jun 5, 2023

@ofborg build alacritty alacritty.passthru.tests

@wegank wegank merged commit ca62b4b into NixOS:staging-next Jun 5, 2023
@wegank wegank deleted the alacritty-darwin branch June 5, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant