Skip to content

Comments

nixos/no-x-libs: add gst-plugins-bad, gst-plugins-rs#231891

Merged
lilyinstarlight merged 3 commits intoNixOS:stagingfrom
SuperSandro2000:gst-plugins-bad
May 25, 2023
Merged

nixos/no-x-libs: add gst-plugins-bad, gst-plugins-rs#231891
lilyinstarlight merged 3 commits intoNixOS:stagingfrom
SuperSandro2000:gst-plugins-bad

Conversation

@SuperSandro2000
Copy link
Member

@SuperSandro2000 SuperSandro2000 commented May 14, 2023

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels May 14, 2023
@SuperSandro2000 SuperSandro2000 requested a review from Artturin May 14, 2023 17:54
@ofborg ofborg bot requested a review from matthewbauer May 14, 2023 18:21
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels May 14, 2023
@SuperSandro2000 SuperSandro2000 changed the base branch from master to staging May 22, 2023 22:38
@SuperSandro2000 SuperSandro2000 changed the title nixos/no-x-libs: add gst-plugins-bad nixos/no-x-libs: add gst-plugins-bad, gst-plugins-rs May 23, 2023
@SuperSandro2000
Copy link
Member Author

SuperSandro2000 commented May 23, 2023

The gst-plugins-base hack is very similar to https://github.com/NixOS/nixpkgs/pull/231185/files#diff-bd924545a322bae41a5f57f50113281417c8ea50fec7801f606840410f492164R169

@SuperSandro2000 SuperSandro2000 force-pushed the gst-plugins-bad branch 2 times, most recently from 4250d20 to fea58a9 Compare May 23, 2023 23:10
lilyinstarlight
lilyinstarlight reviewed May 23, 2023
View reviewed changes
Copy link
Member

@lilyinstarlight lilyinstarlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this! Left a few comments and will test this with that other PR later

@ofborg ofborg bot requested a review from lilyinstarlight May 23, 2023 23:33
@SuperSandro2000 SuperSandro2000 marked this pull request as draft May 24, 2023 20:43
@SuperSandro2000 SuperSandro2000 marked this pull request as ready for review May 24, 2023 21:20
lilyinstarlight
lilyinstarlight approved these changes May 25, 2023
View reviewed changes
Copy link
Member

@lilyinstarlight lilyinstarlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now, thank you!

I tested build of gst-plugins-bad and gst-plugins-rs with and without xlibs successfully on x86_64-linux

@lilyinstarlight lilyinstarlight merged commit 83e9bcb into NixOS:staging May 25, 2023
@SuperSandro2000 SuperSandro2000 deleted the gst-plugins-bad branch May 26, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Artturin Artturin Awaiting requested review from Artturin

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

1 more reviewer

@lilyinstarlight lilyinstarlight lilyinstarlight approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SuperSandro2000 @lilyinstarlight