squirrel-sql: fix the launcher script to allow JDK 19

[khumba]

Description of changes

Squirrel SQL 4.5.1 added support for JDK 19, but the launcher script still requires JDK <=17. This patches the launcher script to check for JDK <=19. This is a belated follow-up to #209299, prompted by #235015.

I confirm that with this change, Squirrel starts now, whereas it errored out before.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • (No reverse dependencies via grep.)
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.05 Release Notes (or backporting 22.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[raboof]

Result of nixpkgs-review pr 235096 run on x86_64-linux 1

1 package built:

• squirrel-sql

[raboof]

Seems to work!

Has this problem/patch been reported upstream? Perhaps we should link to that?

[khumba]

Thanks for testing this. I haven't reported it upstream yet. I am planning to do so, but I wanted to respond here first.

…

On May 31, 2023 12:29:56 a.m. PDT, Arnout Engelen ***@***.***> wrote: @raboof approved this pull request. Seems to work! Has this problem/patch been reported upstream? Perhaps we should link to that? -- Reply to this email directly or view it on GitHub: #235096 (review) You are receiving this because you authored the thread. Message ID: ***@***.***>

[raboof]

Thanks for testing this. I haven't reported it upstream yet. I am planning to do so, but I wanted to respond here first.

👍 (I didn't do any in-depth tests, just start the program)

[khumba]

I think something got mixed up in their release process. Upstream has commits adding 18 and 19 to the some but not all of the launcher scripts on the 4.5.1 branch (7978596a, f869b3a1). And for some reason, the released -standard.zip doesn't have the updated launcher in the root of the ZIP. So this patch should be fine to apply.

[khumba]

This PR is obsoleted by bumping to the fixed version here: #236771

[raboof]

even better!