squirrel-sql: 4.4.0 -> 4.5.1#209299
Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom Jan 23, 2023
Merged
Conversation
khumba
approved these changes
Jan 13, 2023
Contributor
khumba
left a comment
There was a problem hiding this comment.
LGTM, mostly. There is a preexisting issue with JVM version checking that prevents Squirrel from launching: Squirrel 4.5.0+ support Java 19[1] but (most of) the launcher scripts still incorrectly test for Java 17 or older. I'll report this upstream and put a patch together for Nixpkgs. But in the mean time, this update is an overall improvement. When I pass jre = jdk17 then Squirrel 4.5.1 works.
For the record, Squirrel's current behaviour when launching is to display the following message then exit.
Your Java Virtual Machine version must be one of 11 12 13 14 15 16 17 to run SQuirreL
JVM Version used: 19.0.1
JVM Location: /nix/store/lnqmv17pb...-openjdk-19.0.1+10/lib/openjdk
e1mo
added a commit
to e1mo/nixpkgs
that referenced
this pull request
Feb 11, 2023
This was overlooked in NixOS#209299, but will throw a trace when building a system even when the setting was not set.
12 tasks
gador
pushed a commit
to gador/nixpkgs
that referenced
this pull request
Feb 13, 2023
This was overlooked in NixOS#209299, but will throw a trace when building a system even when the setting was not set.
This was referenced May 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/squirrel-sql/versions.
meta.description for squirrel-sql is: Universal SQL Client
meta.homepage for squirrel-sql is: http://squirrel-sql.sourceforge.net/
Updates performed
To inspect upstream changes
Impact
Checks done (click to expand)
passthru.tests, if any, passedRebuild report (if merged into master) (click to expand)
Instructions to test this update (click to expand)
Either download from Cachix:
(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the
trusted-userslist or you can usesudosince root is effectively trusted.Or, build yourself:
After you've downloaded or built it, look at the files and if there are any, run the binaries:
Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of
nixpkgs-reviewrun on x86_64-linux 11 package built:
Maintainer pings
cc @khumba for testing.