Skip to content

squirrel-sql: 4.4.0 -> 4.5.1#209299

Merged
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
r-ryantm:auto-update/squirrel-sql
Jan 23, 2023
Merged

squirrel-sql: 4.4.0 -> 4.5.1#209299
SuperSandro2000 merged 1 commit intoNixOS:masterfrom
r-ryantm:auto-update/squirrel-sql

Conversation

@r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Jan 6, 2023

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/squirrel-sql/versions.

meta.description for squirrel-sql is: Universal SQL Client

meta.homepage for squirrel-sql is: http://squirrel-sql.sourceforge.net/

Updates performed
  • Version update
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 4.5.1 with grep in /nix/store/5p716n3i2m1lni3a8ilvalsq94sab8g6-squirrel-sql-4.5.1
  • found 4.5.1 in filename of file in /nix/store/5p716n3i2m1lni3a8ilvalsq94sab8g6-squirrel-sql-4.5.1

Rebuild report (if merged into master) (click to expand)
1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
squirrel-sql
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/5p716n3i2m1lni3a8ilvalsq94sab8g6-squirrel-sql-4.5.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A squirrel-sql https://github.com/r-ryantm/nixpkgs/archive/6f3fc8199aba09a1260afa75987be9599369bcb7.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/5p716n3i2m1lni3a8ilvalsq94sab8g6-squirrel-sql-4.5.1
ls -la /nix/store/5p716n3i2m1lni3a8ilvalsq94sab8g6-squirrel-sql-4.5.1/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • squirrel-sql

Maintainer pings

cc @khumba for testing.

@ofborg ofborg bot requested a review from khumba January 6, 2023 12:45
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 6, 2023
Copy link
Contributor

@khumba khumba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, mostly. There is a preexisting issue with JVM version checking that prevents Squirrel from launching: Squirrel 4.5.0+ support Java 19[1] but (most of) the launcher scripts still incorrectly test for Java 17 or older. I'll report this upstream and put a patch together for Nixpkgs. But in the mean time, this update is an overall improvement. When I pass jre = jdk17 then Squirrel 4.5.1 works.

For the record, Squirrel's current behaviour when launching is to display the following message then exit.

Your Java Virtual Machine version must be one of 11 12 13 14 15 16 17 to run SQuirreL
JVM Version used: 19.0.1
JVM Location: /nix/store/lnqmv17pb...-openjdk-19.0.1+10/lib/openjdk

[1] http://www.squirrelsql.org/#latestnews

@SuperSandro2000 SuperSandro2000 added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jan 23, 2023
@SuperSandro2000 SuperSandro2000 merged commit 109fc99 into NixOS:master Jan 23, 2023
@r-ryantm r-ryantm deleted the auto-update/squirrel-sql branch January 23, 2023 23:03
e1mo added a commit to e1mo/nixpkgs that referenced this pull request Feb 11, 2023
This was overlooked in NixOS#209299, but will throw a trace when building a
system even when the setting was not set.
gador pushed a commit to gador/nixpkgs that referenced this pull request Feb 13, 2023
This was overlooked in NixOS#209299, but will throw a trace when building a
system even when the setting was not set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants