Closed
Conversation
The current version of squirrel doesn't support the current default JRE in nixpkgs (19). Since this is a property of squirrel-sql, changed it in squirrel-sql's `default.nix`.
12 tasks
Contributor
|
Hello @raboof, Have you seen [1]? The current version of Squirrel, the Java parts at least, do actually support Java 19 (as announced in the release notes[2])...however the launcher scripts are out of date and as far as I can tell just need to have newer version numbers added to a version check. I mean to add a patch for this, but it fell off my radar, so thanks for the reminder. Do you mind if we continue with this approach instead? I think it would be preferable to forcing users to have an older, extra JVM on their systems. I've created a PR for this fix: #235096 Thanks! [1] #209299 (review) |
Member
Author
|
I hadn't seen that, much better, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
The current version of squirrel doesn't support the current default JRE in nixpkgs (19). Since this is a property of squirrel-sql, changed it in squirrel-sql's
default.nix.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)/cc @khumba