Skip to content

squirrel-sql: use supported JRE#235015

Closed
raboof wants to merge 1 commit intoNixOS:masterfrom
raboof:squirrel-sql-use-supported-jre
Closed

squirrel-sql: use supported JRE#235015
raboof wants to merge 1 commit intoNixOS:masterfrom
raboof:squirrel-sql-use-supported-jre

Conversation

@raboof
Copy link
Member

@raboof raboof commented May 30, 2023

Description of changes

The current version of squirrel doesn't support the current default JRE in nixpkgs (19). Since this is a property of squirrel-sql, changed it in squirrel-sql's default.nix.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

/cc @khumba

The current version of squirrel doesn't support the current default JRE
in nixpkgs (19). Since this is a property of squirrel-sql, changed it
in squirrel-sql's `default.nix`.
@ofborg ofborg bot requested a review from khumba May 30, 2023 16:13
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels May 30, 2023
@khumba
Copy link
Contributor

khumba commented May 31, 2023

Hello @raboof,

Have you seen [1]? The current version of Squirrel, the Java parts at least, do actually support Java 19 (as announced in the release notes[2])...however the launcher scripts are out of date and as far as I can tell just need to have newer version numbers added to a version check. I mean to add a patch for this, but it fell off my radar, so thanks for the reminder. Do you mind if we continue with this approach instead? I think it would be preferable to forcing users to have an older, extra JVM on their systems. I've created a PR for this fix: #235096

Thanks!

[1] #209299 (review)
[2] http://www.squirrelsql.org/#latestnews

@raboof
Copy link
Member Author

raboof commented May 31, 2023

I hadn't seen that, much better, thanks!

@raboof raboof closed this May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants