squirrel-sql: Use jdk17 instead of jre#263758
Closed
Mr-Andersen wants to merge 1 commit intoNixOS:masterfrom
Mr-Andersen:master
Closed
squirrel-sql: Use jdk17 instead of jre#263758Mr-Andersen wants to merge 1 commit intoNixOS:masterfrom Mr-Andersen:master
Mr-Andersen wants to merge 1 commit intoNixOS:masterfrom
Mr-Andersen:master
Conversation
ofborg
bot
added
10.rebuild-darwin: 0
Contributor
|
Hi, please provide a reasoning for this change. As I see it, jre is already pointing to JDK 19, so this is a downgrade. |
Contributor
Author
|
@yu-re-ka ohh sorry, I forgot. squirell-sql refuses to run with JVM >17. |
Contributor
|
Please open a new PR targeting the release-23.05 branch. On nixos-unstable this problem does not exist, because squirrel-sql 4.6.0 supports up to JDK 20. |
Contributor
|
Hey, For backporting, another option could be to apply the fix to the launcher script in the PR here[1], then pulling in an additional JVM isn't needed. That PR was closed because 4.6.0 got released quickly, but it should work on NixOS 23.05. Up to you, and thanks. [1] #235096 |
Contributor
Author
|
If it works on unstable, than it's not important |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Depend on
jdk17instead ofjreThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)