Skip to content

buildRustPackage: remove git from nativeBuildInputs#207804

Merged
zowoq merged 1 commit intoNixOS:stagingfrom
qowoz:rust-git
Dec 27, 2022
Merged

buildRustPackage: remove git from nativeBuildInputs#207804
zowoq merged 1 commit intoNixOS:stagingfrom
qowoz:rust-git

Conversation

@zowoq
Copy link
Contributor

@zowoq zowoq commented Dec 26, 2022

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@Atemu @zowoq
buildRustPackage: remove git from nativeBuildInputs
df8efdb 
Having git in nativeBuildInputs causes thousands of rebuilds when git is touched
because every derivation that somehow transiently depends on a rust package will
change. See #205682 for instance.

AFAICT git is unused. Only the fetcher needs git which it has already.

Fixes #205804
@zowoq zowoq requested review from LnL7 and Mic92 as code owners December 26, 2022 06:10
@github-actions github-actions bot added the 6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. label Dec 26, 2022
@zowoq zowoq mentioned this pull request Dec 26, 2022
Closed
13 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Dec 26, 2022
@zowoq zowoq merged commit 3eec3c8 into NixOS:staging Dec 27, 2022
@zowoq zowoq deleted the rust-git branch December 27, 2022 08:37
@SuperSandro2000 SuperSandro2000 mentioned this pull request Jan 6, 2023
Closed
This was referenced Jan 14, 2023
Merged
Merged
Merged
@johnrichardrinehart johnrichardrinehart mentioned this pull request Jan 17, 2023
Merged
13 tasks
@figsoda figsoda mentioned this pull request Jan 17, 2023
Merged
13 tasks
cole-h added a commit to cole-h/nixpkgs that referenced this pull request Jan 18, 2023
@cole-h
mullvad: fix build
857f76f 
NixOS#207804 removed git from
nativeBuildInputs for buildRustPackage, which is apparently what allowed
the build.rs to work here. Bring it back for this single package.
@cole-h cole-h mentioned this pull request Jan 18, 2023
Merged
13 tasks
cole-h added a commit that referenced this pull request Jan 19, 2023
@cole-h
mullvad: fix build
afed882 
#207804 removed git from
nativeBuildInputs for buildRustPackage, which is apparently what allowed
the build.rs to work here. Bring it back for this single package.
@amesgen amesgen mentioned this pull request Feb 13, 2023
Merged
12 tasks
akshaymankar added a commit to wireapp/wire-server that referenced this pull request Feb 15, 2023
@akshaymankar
pkgs.{zauth,mls-test-cli}: Add gitMinimal to nativeBuildInputs
a6a0b82 
Broken due to NixOS/nixpkgs#207804
akshaymankar added a commit to wireapp/wire-server that referenced this pull request Feb 15, 2023
@akshaymankar
Bump nixpkgs (#3084)
06933c3 
* Bump nixpkgs

* Fix manual-overrides following nixpkgs bump

Sort the "sections" of the overrides so it is kinda obvious where to add new
overrides.

* Avoid checking text-icu-translit

The tests don't compile due to a function no longer being exported from a module
in text-icu.

* Add name to nginx zauth module, it is compulsory now

* Shellcheck decided to do more checks, fix them

* pkgs.{zauth,mls-test-cli}: Add gitMinimal to nativeBuildInputs

Broken due to NixOS/nixpkgs#207804

* Jailbreak polysemy to allow newer doctest

* Fix compile errors and warnings

* Add /tmp to nginz image

* Changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mic92 Mic92 Awaiting requested review from Mic92

@LnL7 LnL7 Awaiting requested review from LnL7

Assignees

No one assigned

Labels

6.topic: rust General-purpose programming language emphasizing performance, type safety, and concurrency. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zowoq @Atemu