Skip to content

dogdns: fix build, add figsoda as a maintainer#210738

Merged
figsoda merged 1 commit intoNixOS:masterfrom
figsoda:dog
Jan 17, 2023
Merged

dogdns: fix build, add figsoda as a maintainer#210738
figsoda merged 1 commit intoNixOS:masterfrom
figsoda:dog

Conversation

@figsoda
Copy link
Member

@figsoda figsoda commented Jan 14, 2023 •
edited
Loading

Description of changes

fix build after #207804 and make reproducible

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@figsoda figsoda changed the title dogdns: fix build, add figsoda as a maintainer [next] dogdns: fix build, add figsoda as a maintainer Jan 14, 2023
@figsoda figsoda mentioned this pull request Jan 14, 2023
Merged
13 tasks
@figsoda figsoda changed the base branch from staging-next to master January 14, 2023 18:18
@figsoda figsoda changed the title [next] dogdns: fix build, add figsoda as a maintainer dogdns: fix build, add figsoda as a maintainer Jan 14, 2023
@ofborg ofborg bot requested review from Ma27 and bbigras January 14, 2023 18:42
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jan 14, 2023
@figsoda figsoda removed the request for review from Ma27 January 17, 2023 17:13
@figsoda figsoda merged commit d3f8839 into NixOS:master Jan 17, 2023
@figsoda figsoda deleted the dog branch January 17, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bbigras bbigras Awaiting requested review from bbigras

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@figsoda