Skip to content

git: 2.38.1 -> 2.39.0#205682

Merged
zowoq merged 1 commit intoNixOS:stagingfrom
qowoz:git
Dec 26, 2022
Merged

git: 2.38.1 -> 2.39.0#205682
zowoq merged 1 commit intoNixOS:stagingfrom
qowoz:git

Conversation

@zowoq
Copy link
Contributor

@zowoq zowoq commented Dec 11, 2022 •
edited
Loading

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.05 Release Notes (or backporting 22.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from globin, primeos and wmertens December 11, 2022 22:27
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Dec 11, 2022
@Atemu
Copy link
Member

Atemu commented Dec 12, 2022

Why does git trigger this many rebuilds? Shouldn't it mostly be used in FODs?

@zowoq zowoq changed the title git: 2.38.1 -> 2.38.2 git: 2.38.1 -> 2.39.0 Dec 12, 2022
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Dec 12, 2022

Why does git trigger this many rebuilds? Shouldn't it mostly be used in FODs?

mainly because build functions use it like buildRustPackage https://github.com/NixOS/nixpkgs/blob/master/pkgs/build-support/rust/build-rust-package/default.nix#L120

@Atemu Atemu mentioned this pull request Dec 12, 2022
Closed
@Atemu Atemu mentioned this pull request Dec 12, 2022
Closed
13 tasks
@zowoq zowoq mentioned this pull request Dec 12, 2022
Closed
13 tasks
Atemu added a commit to Atemu/nixpkgs that referenced this pull request Dec 14, 2022
@Atemu
buildRustPackage: remove git from nativeBuildInputs
6e20856 
Having git in nativeBuildInputs causes thousands of rebuilds when git is touched
because every derivation that somehow transiently depends on a rust package will
change. See NixOS#205682 for instance.

AFAICT git is unused. Only the fetcher needs git which it has already.

Fixes NixOS#205804
Atemu added a commit to Atemu/nixpkgs that referenced this pull request Dec 15, 2022
@Atemu
buildRustPackage: remove git from nativeBuildInputs
fea34b3 
Having git in nativeBuildInputs causes thousands of rebuilds when git is touched
because every derivation that somehow transiently depends on a rust package will
change. See NixOS#205682 for instance.

AFAICT git is unused. Only the fetcher needs git which it has already.

Fixes NixOS#205804
@primeos primeos mentioned this pull request Dec 15, 2022
Closed
@zowoq zowoq marked this pull request as draft December 26, 2022 00:21
@zowoq zowoq marked this pull request as ready for review December 26, 2022 00:22
@zowoq zowoq merged commit 69ba914 into NixOS:staging Dec 26, 2022
@zowoq zowoq deleted the git branch December 26, 2022 06:11
zowoq pushed a commit that referenced this pull request Dec 27, 2022
@Atemu @zowoq
buildRustPackage: remove git from nativeBuildInputs
3eec3c8 
Having git in nativeBuildInputs causes thousands of rebuilds when git is touched
because every derivation that somehow transiently depends on a rust package will
change. See #205682 for instance.

AFAICT git is unused. Only the fetcher needs git which it has already.

Fixes #205804
This was referenced Jan 17, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@globin globin Awaiting requested review from globin

@primeos primeos Awaiting requested review from primeos

@wmertens wmertens Awaiting requested review from wmertens

Assignees

No one assigned

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zowoq @Atemu @SuperSandro2000