Conversation
zebot
added
the
ok-to-test
akshaymankar
force-pushed
the
nixpkgs-bump-2023-02-15
branch
from
ff05fb3 to
2422ccc
Compare
Sort the "sections" of the overrides so it is kinda obvious where to add new overrides.
The tests don't compile due to a function no longer being exported from a module in text-icu.
akshaymankar
force-pushed
the
nixpkgs-bump-2023-02-15
branch
from
4e4eccf to
dbac6f4
Compare
fisx
approved these changes
Feb 15, 2023
Contributor
fisx
left a comment
fisx
left a comment
There was a problem hiding this comment.
I would really prefer an internal changelog entry saying 'bump nix/sources.json'. It's a pretty substantial change in terms of code; the benefit would be that this information wouldn't be lossed to anybody debugging issues with it; and I don't see the harm.
Also, if you sort large text passages by line in a separate commit that doesn't have any actual changes, that makes it easier to review.
Otherwise LGTM!
This was referenced Mar 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.d