pythonPackages.unittestCheckHook: align to docs, support dynamic flags in preCheck script#191948
Closed
impl wants to merge 2 commits intoNixOS:stagingfrom
Closed
pythonPackages.unittestCheckHook: align to docs, support dynamic flags in preCheck script#191948impl wants to merge 2 commits intoNixOS:stagingfrom
preCheck script#191948impl wants to merge 2 commits intoNixOS:stagingfrom
Conversation
f46e62f to
46cf3da
Compare
winterqt
requested changes
Sep 19, 2022
Member
winterqt
left a comment
There was a problem hiding this comment.
so this PR aligns the script behavior to the docs/stdenv instead of just updating the docs to match the current implementation.
Please do this instead. It looks like I forgot to change the docs after #185430 (comment) -- unittestFlagsArray is correct (for now, anyways).
Member
Author
Ah ok, will do! I'll open a new PR against master since it won't require a mass-rebuild then. Thanks! |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
In the docs, the flags for the
unittestCheckHookare described as belonging inunittestFlags, but it seems that the hook script was expecting them to be set asunittestFlagsArray. In stdenv at least it seems that the*Arrayvariants are used for dynamically configuring the flags in apre*script, e.g.preCheck = "unittestFlagsArray+=(--foo)", so this PR aligns the script behavior to the docs/stdenv instead of just updating the docs to match the current implementation.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes