pythonPackages.unittestCheckHook: init

[winterqt]

Description of changes

This adds a new hook, unittestCheckHook, that runs python -m unittest discover, as well as migrating the majority of packages that use unittest to it.

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 22.11 Release Notes (or backporting 22.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
  • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
• Fits CONTRIBUTING.md.

[winterqt]

Wonder why ofborg-eval-package-list never failed with the previous commits (when it should have).

Edit, hours later: but it did for the same type of problem just now...?

[winterqt]

I'm not sure if this is the best way to do things.

The issue that I ran into was that if I did python -m unittest discover "${unittestFlags[@]}", a flags value of [ "-s" "tests" ] would expand to a single argument, -s tests, which argparse (which unittest uses) would parse as the value for the -s argument being tests (with a space).

[SuperSandro2000]

maybe this https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/interpreters/python/hooks/pytest-check-hook.sh#L52-L53 helps you?

[winterqt]

That's basically doing what I'm doing here, as far as I can tell -- I believe it has to do that specifically so it can add its own arguments if needed.

[winterqt]

I don't like that OfBorg added the clean up label, though I don't think it gives specifics as to why. 😕

As far as I know, I fixed every issue that caused packages to not eval, so I'm not sure what else it would be adding that for (even if it should fail for that)...

[SuperSandro2000]

I don't like that OfBorg added the clean up label, though I don't think it gives specifics as to why. confused

don't worry about it. I am not sure what triggered it but maybe the treewide change.

[FRidh]

As it is now, the unittest hook should be added to checkInputs, but after #185406 it needs to go to nativeCheckInputs.

[winterqt]

As it is now, the unittest hook should be added to checkInputs

Fixed.

[mweinelt]

Looks good to me, one more nit.

[vcunat]

This broke tests in .bitstring: https://hydra.nixos.org/build/187598212
(the "treewide" commit, according to my bisect)

[winterqt]

Yes, someone already noted that -- there's a quick fix but also a more proper one that should be upstreamed. See https://matrix.to/#/!kjdutkOsheZdjqYmqp%3Anixos.org/%24_WKyurbQoNXb49piMvNidpULeGz7zFJh-LFM4HoAttE

[vcunat]

In PR #187531

[vcunat]

Other regressions probably won't have significant impact, but let me post them here anyway, in case someone's interested:

• .plac https://hydra.nixos.org/build/187634946

[winterqt]

I made #187778 to fix regressions (drafted until latest eval completes).