Skip to content

doc/python: fix attr name for unittestCheckHook flags#191956

Merged
mweinelt merged 1 commit intoNixOS:masterfrom
impl:python-unittest-hook-doc
Jan 28, 2023
Merged

doc/python: fix attr name for unittestCheckHook flags#191956
mweinelt merged 1 commit intoNixOS:masterfrom
impl:python-unittest-hook-doc

Conversation

@impl
Copy link
Member

@impl impl commented Sep 19, 2022

Description of changes

Follow up to #191948, since we don't (yet?) want to remove *Array from the name.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@impl impl requested a review from FRidh as a code owner September 19, 2022 18:55
@impl impl requested a review from winterqt September 19, 2022 18:55
@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 8.has: documentation This PR adds or changes documentation labels Sep 19, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Sep 19, 2022
@impl
Copy link
Member Author

impl commented Jan 26, 2023

@winterqt, any concerns about this one? Can this be merged? :)

@mweinelt
Copy link
Member

mweinelt commented Jan 28, 2023

Was the heading level also off? If so add a remark to your commit message.

@impl
doc/python: fix attr name for unittestCheckHook flags
3bec41f 
The name should end in Array per the current conventions.

This change also contains some minor formatting fixes, as the heading
levels were inconsistent.
@impl impl force-pushed the python-unittest-hook-doc branch from 5d7ba67 to 3bec41f Compare January 28, 2023 21:21
@impl impl requested a review from mweinelt as a code owner January 28, 2023 21:21
@mweinelt mweinelt merged commit 6bc2314 into NixOS:master Jan 28, 2023
@impl impl deleted the python-unittest-hook-doc branch January 28, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mweinelt mweinelt mweinelt approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@winterqt winterqt Awaiting requested review from winterqt

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@impl @mweinelt