pythonPackages.unittestCheckHook: align to docs, support dynamic flags in preCheck script

pkgs/applications/misc/haxor-news/default.nix

@@ -54,7 +54,7 @@ buildPythonApplication rec {
 
   checkInputs = [ unittestCheckHook mock ];
 
-  unittestFlagsArray = [ "-s" "tests" "-v" ];
+  unittestFlags = [ "-s" "tests" "-v" ];
 
   meta = with lib; {
     homepage = "https://github.com/donnemartin/haxor-news";

pkgs/development/interpreters/python/hooks/unittest-check-hook.sh

@@ -5,7 +5,13 @@ unittestCheckPhase() {
     echo "Executing unittestCheckPhase"
     runHook preCheck
 
-    eval "@pythonCheckInterpreter@ -m unittest discover $unittestFlagsArray"
+    # Old bash empty array hack
+    # shellcheck disable=SC2086
+    local flagsArray=(
+        ${unittestFlags:-} "${unittestFlagsArray[@]}"
+    )
+    echoCmd 'unittest check flags' "${flagsArray[@]}"
+    @pythonCheckInterpreter@ -m unittest discover "${flagsArray[@]}"
 
     runHook postCheck
     echo "Finished executing unittestCheckPhase"

pkgs/development/python-modules/arxiv2bib/default.nix

@@ -18,7 +18,7 @@ buildPythonPackage rec {
   };
 
   checkInputs = [ unittestCheckHook mock ];
-  unittestFlagsArray = [ "-s" "tests" ];
+  unittestFlags = [ "-s" "tests" ];
 
   meta = with lib; {
     description = "Get a BibTeX entry from an arXiv id number, using the arxiv.org API";

pkgs/development/python-modules/backports_tempfile/default.nix

@@ -24,7 +24,7 @@ buildPythonPackage rec {
 
   checkInputs = [ unittestCheckHook ];
 
-  unittestFlagsArray = [ "-s" "tests" ];
+  unittestFlags = [ "-s" "tests" ];
 
   meta = {
     description = "Backport of new features in Python's tempfile module";

pkgs/development/python-modules/backports_weakref/default.nix

@@ -22,7 +22,7 @@ buildPythonPackage rec {
 
   checkInputs = [ unittestCheckHook ];
 
-  unittestFlagsArray = [ "tests" ];
+  unittestFlags = [ "tests" ];
 
   meta = with lib; {
     description = "Backports of new features in Python’s weakref module";

pkgs/development/python-modules/bitstring/default.nix

@@ -26,7 +26,7 @@ buildPythonPackage rec {
 
   checkInputs = [ unittestCheckHook ];
 
-  unittestFlagsArray = [ "-s" "test" ];
+  unittestFlags = [ "-s" "test" ];
 
   pythonImportsCheck = [ "bitstring" ];
 

pkgs/development/python-modules/cvxopt/default.nix

@@ -53,7 +53,7 @@ buildPythonPackage rec {
 
   checkInputs = [ unittestCheckHook ];
 
-  unittestFlagsArray = [ "-s" "tests" ];
+  unittestFlags = [ "-s" "tests" ];
 
   meta = with lib; {
     homepage = "http://cvxopt.org/";

pkgs/development/python-modules/fido2/default.nix

@@ -21,7 +21,7 @@ buildPythonPackage rec {
 
   checkInputs = [ unittestCheckHook mock pyfakefs ];
 
-  unittestFlagsArray = [ "-v" ];
+  unittestFlags = [ "-v" ];
 
   pythonImportsCheck = [ "fido2" ];
 

pkgs/development/python-modules/flask-babel/default.nix

@@ -26,7 +26,7 @@ buildPythonPackage rec {
     speaklater
   ];
 
-  unittestFlagsArray = [ "-s" "tests" ];
+  unittestFlags = [ "-s" "tests" ];
 
   meta = with lib; {
     description = "Adds i18n/l10n support to Flask applications";

pkgs/development/python-modules/greenlet/default.nix

@@ -18,7 +18,7 @@ buildPythonPackage rec {
 
   checkInputs = [ unittestCheckHook ];
 
-  unittestFlagsArray = [ "-v" "greenlet.tests" ];
+  unittestFlags = [ "-v" "greenlet.tests" ];
 
   meta = with lib; {
     homepage = "https://github.com/python-greenlet/greenlet";

pkgs/development/python-modules/isodate/default.nix

@@ -18,7 +18,7 @@ buildPythonPackage rec {
 
   checkInputs = [ unittestCheckHook ];
 
-  unittestFlagsArray = [ "-s" "src/isodate/tests" ];
+  unittestFlags = [ "-s" "src/isodate/tests" ];
 
   meta = with lib; {
     description = "ISO 8601 date/time parser";

pkgs/development/python-modules/jxmlease/default.nix

@@ -24,7 +24,7 @@ buildPythonPackage rec {
 
   checkInputs = [ unittestCheckHook ];
 
-  unittestFlagsArray = [ "-v" ];
+  unittestFlags = [ "-v" ];
 
   meta = with lib; {
     description = "Converts between XML and intelligent Python data structures";

pkgs/development/python-modules/mat2/default.nix

@@ -95,7 +95,7 @@ buildPythonPackage rec {
 
   checkInputs = [ unittestCheckHook ];
 
-  unittestFlagsArray = [ "-v" ];
+  unittestFlags = [ "-v" ];
 
   meta = with lib; {
     description = "A handy tool to trash your metadata";

pkgs/development/python-modules/mkdocs/default.nix

@@ -52,7 +52,7 @@ buildPythonPackage rec {
     mock
   ];
 
-  unittestFlagsArray = [ "-v" "-p" "'*tests.py'" "mkdocs" ];
+  unittestFlags = [ "-v" "-p" "'*tests.py'" "mkdocs" ];
 
   pythonImportsCheck = [ "mkdocs" ];
 

pkgs/development/python-modules/pycparser/default.nix

@@ -11,7 +11,7 @@ buildPythonPackage rec {
 
   checkInputs = [ unittestCheckHook ];
 
-  unittestFlagsArray = [ "-s" "tests" ];
+  unittestFlags = [ "-s" "tests" ];
 
   meta = with lib; {
     description = "C parser in Python";

pkgs/development/python-modules/pysensors/default.nix

@@ -19,7 +19,7 @@ buildPythonPackage {
 
   checkInputs = [ unittestCheckHook ];
 
-  unittestFlagsArray = [ "-s" "tests" ];
+  unittestFlags = [ "-s" "tests" ];
 
   meta = with lib; {
     maintainers = with maintainers; [ guibou ];

pkgs/development/python-modules/pyserial/default.nix

@@ -29,7 +29,7 @@ buildPythonPackage rec {
 
   checkInputs = [ unittestCheckHook ];
 
-  unittestFlagsArray = [ "-s" "test" ];
+  unittestFlags = [ "-s" "test" ];
 
   pythonImportsCheck = [
     "serial"

pkgs/development/python-modules/pytz/default.nix

@@ -11,7 +11,7 @@ buildPythonPackage rec {
 
   checkInputs = [ unittestCheckHook ];
 
-  unittestFlagsArray = [ "-s" "pytz/tests" ];
+  unittestFlags = [ "-s" "pytz/tests" ];
 
   pythonImportsCheck = [ "pytz" ];
 

pkgs/development/python-modules/readlike/default.nix

@@ -17,7 +17,7 @@ buildPythonPackage rec {
 
   checkInputs = [ unittestCheckHook ];
 
-  unittestFlagsArray = [ "-s" "tests" ];
+  unittestFlags = [ "-s" "tests" ];
 
   meta = with lib; {
     description = "GNU Readline-like line editing module";

pkgs/development/python-modules/sphinx-testing/default.nix

@@ -19,7 +19,7 @@ buildPythonPackage rec {
   checkInputs = [ unittestCheckHook mock ];
   propagatedBuildInputs = [ sphinx six ];
 
-  unittestFlagsArray = [ "-s" "tests" ];
+  unittestFlags = [ "-s" "tests" ];
 
   # Test failures https://github.com/sphinx-doc/sphinx-testing/issues/5
   doCheck = false;

pkgs/development/python-modules/sphinxcontrib-blockdiag/default.nix

@@ -25,7 +25,7 @@ buildPythonPackage rec {
 
   checkInputs = [ unittestCheckHook ];
 
-  unittestFlagsArray = [ "-s" "tests" ];
+  unittestFlags = [ "-s" "tests" ];
 
   meta = with lib; {
     description = "Sphinx blockdiag extension";

pkgs/development/python-modules/tornado/4.nix

@@ -20,7 +20,7 @@ buildPythonPackage rec {
 
   # We specify the name of the test files to prevent
   # https://github.com/NixOS/nixpkgs/issues/14634
-  unittestFlagsArray = [ "*_test.py" ];
+  unittestFlags = [ "*_test.py" ];
 
   __darwinAllowLocalNetworking = true;
 

pkgs/development/python-modules/tornado/5.nix

@@ -20,7 +20,7 @@ buildPythonPackage rec {
 
   # We specify the name of the test files to prevent
   # https://github.com/NixOS/nixpkgs/issues/14634
-  unittestFlagsArray = [ "*_test.py" ];
+  unittestFlags = [ "*_test.py" ];
 
   __darwinAllowLocalNetworking = true;
 

pkgs/development/python-modules/trytond/default.nix

@@ -67,7 +67,7 @@ buildPythonPackage rec {
     export DB_NAME=":memory:";
   '';
 
-  unittestFlagsArray = [ "-s" "trytond.tests" ];
+  unittestFlags = [ "-s" "trytond.tests" ];
 
   meta = with lib; {
     description = "The server of the Tryton application platform";

pkgs/development/python-modules/unidiff/default.nix

@@ -11,7 +11,7 @@ buildPythonPackage rec {
 
   checkInputs = [ unittestCheckHook ];
 
-  unittestFlagsArray = [ "-s" "tests" ];
+  unittestFlags = [ "-s" "tests" ];
 
   pythonImportsCheck = [ "unidiff" ];
 

pkgs/development/python-modules/untangle/default.nix

@@ -18,7 +18,7 @@ buildPythonPackage rec {
 
   checkInputs = [ unittestCheckHook ];
 
-  unittestFlagsArray = [ "-s" "tests" ];
+  unittestFlags = [ "-s" "tests" ];
 
   meta = with lib; {
     description = "Convert XML documents into Python objects";

pkgs/development/python-modules/vapoursynth/default.nix

@@ -17,7 +17,7 @@ buildPythonPackage {
     unittestCheckHook
   ];
 
-  unittestFlagsArray = [ "-s" "$src/test" "-p" "'*test.py'" ];
+  unittestFlags = [ "-s" "$src/test" "-p" "'*test.py'" ];
 
   passthru = {
     withPlugins = plugins:

pkgs/development/python-modules/webcolors/default.nix

@@ -19,7 +19,7 @@ buildPythonPackage rec {
 
   checkInputs = [ unittestCheckHook ];
 
-  unittestFlagsArray = [ "-s" "tests" ];
+  unittestFlags = [ "-s" "tests" ];
 
   pythonImportsCheck = [
     "webcolors"

pkgs/development/python-modules/zake/default.nix

@@ -25,7 +25,7 @@ buildPythonPackage rec {
       --replace "test_child_watch_no_create" "_test_child_watch_no_create"
   '';
 
-  unittestFlagsArray = [ "zake/tests" ];
+  unittestFlags = [ "zake/tests" ];
 
   meta = with lib; {
     homepage = "https://github.com/yahoo/Zake";

pkgs/development/python-modules/zope_copy/default.nix

@@ -23,7 +23,7 @@ buildPythonPackage rec {
   doCheck = !isPy27; # namespace conflicts
   checkInputs = [ unittestCheckHook zope_location zope_schema ];
 
-  unittestFlagsArray = [ "-s" "src/zope/copy" ];
+  unittestFlags = [ "-s" "src/zope/copy" ];
 
   meta = {
     maintainers = with lib.maintainers; [ domenkozar ];

pkgs/development/python2-modules/typing/default.nix

@@ -22,7 +22,7 @@ in buildPythonPackage rec {
 
   checkInputs = [ unittestCheckHook ];
 
-  unittestFlagsArray = [ "-s" testDir ];
+  unittestFlags = [ "-s" testDir ];
 
   meta = with lib; {
     description = "Backport of typing module to Python versions older than 3.5";