python310Packages.nbconvert: use mistune 2.x#186804
Merged
smancill merged 1 commit intoNixOS:masterfrom Aug 17, 2022
Merged
Conversation
github-actions
bot
added
the
6.topic: python
ofborg
bot
added
10.rebuild-darwin: 101-500
Contributor
Author
|
@ofborg build python310Packages.jupyter |
13 tasks
Contributor
|
Result of 45 packages failed to build:
76 packages built:
|
Contributor
Author
|
Too many failing packages still, that's not good.
|
Contributor
Author
|
@ofborg build python310Packages.jupyterlab python310Packages.folium |
Contributor
Author
|
A quick glance shows that, along with
|
Member
|
Result of 51 packages failed to build and already failed to build on hydra master:
2 packages failed to build and are new build failures:
67 packages built:
The following issues got detected with the above build packages. Detailsihaskell:Package is missing a meta section. got build log for '/nix/store/4ss4y20jchfj2v2808m19kgryawn6v49-ihaskell-with-packages' from 'daemon' |
risicle
reviewed
Aug 15, 2022
Contributor
|
As others are finding, what with the muddle of recent breakages it's hard to tell, but I don't think this causes any new breakages for |
dotlambda
approved these changes
Aug 16, 2022
Member
|
Some tests related to folium fail. |
bobby285271
added
the
12.approvals: 1
Contributor
|
There's also a new version of nbconvert available: 6.5.3 |
Contributor
Author
It was already broken, so it's unrelated to this PR: https://hydra.nixos.org/job/nixpkgs/trunk/python310Packages.folium.x86_64-linux |
mistune 0.8 was removed by NixOS#186272.
Contributor
Author
Support for mistune 2.x was added in the 7.x RC, so that new 6.5.3 version will not affect this. |
smancill
force-pushed
the
python3-nconvert-use-mistune-2.x
branch
from
ff332d7 to
8d05ef5
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/jupyter-broken-in-22-05/21108/1 |
1 task
Contributor
|
Successfully created backport PR #187550 for |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
mistune 0.8 was removed by #186272.
Patch the sources to use mistune 2.x.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes