pythonPackages.nbclassic: fix build failure due to nodejs deps#186703
Merged
smancill merged 2 commits intoNixOS:masterfrom Aug 18, 2022
Merged
pythonPackages.nbclassic: fix build failure due to nodejs deps#186703smancill merged 2 commits intoNixOS:masterfrom
smancill merged 2 commits intoNixOS:masterfrom
Conversation
Contributor
|
@ofborg build python310Packages.nbclassic python310Packages.jupyterlab |
Contributor
|
Ah, it cannot build on ofborg because of the insecure dependency. |
Contributor
|
Result of 1 package marked as broken and skipped:
3 packages failed to build:
7 packages built:
|
da130e5 to
ddddfc7
Compare
mofrim
commented
Aug 15, 2022
Contributor
13 tasks
smancill
reviewed
Aug 17, 2022
Contributor
|
Result of 1 package marked as broken and skipped:
3 packages failed to build:
7 packages built:
|
smancill
approved these changes
Aug 17, 2022
Contributor
|
Result of 4 packages failed to build:
9 packages built:
nix log /nix/store/gx97h2k4rdyd7jb7yj1mh5bk85gxs3cz-python3.9-jupyterlab_server-2.15.0.drv (build failure) |
fogti
approved these changes
Aug 18, 2022
This was referenced Aug 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
using v4.3.0
nbclassicgithub version as src for this package would require dealing with bower nodejs dependencies which would be, given the fact that bower is almost deprecated, cumbersome to deal with directly (i tried for a while...).So i decided to use the Pypi-version where all node-deps are included. Also an new dependency
notebook_shimhad to be packaged.I only started looking into this matter because another package i maintain
manimdid not build anymore because of nbclassic not building.Unfortunately ATM nbclassic only builds with
export NIXPKGS_ALLOW_INSECURE=1because ofpythonPackages.mistune, see also PR #186272.Closes #186694, closes #185028.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes