Skip to content

python310Packages.mistune: 0.8.4 -> 2.0.4#186272

Merged
dotlambda merged 2 commits intoNixOS:masterfrom
dotlambda:mistune-single-version
Aug 15, 2022
Merged

python310Packages.mistune: 0.8.4 -> 2.0.4#186272
dotlambda merged 2 commits intoNixOS:masterfrom
dotlambda:mistune-single-version

Conversation

@dotlambda
Copy link
Member

@dotlambda dotlambda commented Aug 12, 2022

Description of changes
Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python Python is a high-level, general-purpose programming language. labels Aug 12, 2022
@dotlambda dotlambda mentioned this pull request Aug 12, 2022
Merged
13 tasks
@vcunat vcunat added the 1.severity: channel blocker Blocks a channel label Aug 12, 2022
@ofborg ofborg bot added the 8.has: clean-up This PR removes packages or removes other cruft label Aug 12, 2022
@ofborg ofborg bot requested review from legendofmiracles and marsam August 12, 2022 12:02
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Aug 12, 2022
@vcunat vcunat removed the 1.severity: channel blocker Blocks a channel label Aug 12, 2022
AndersonTorres
AndersonTorres suggested changes Aug 12, 2022
View reviewed changes
pkgs/development/python-modules/m2r/default.nix
description = "Markdown to reStructuredText converter";
license = licenses.mit;
maintainers = with maintainers; [ SuperSandro2000 ];
maintainers = with maintainers; [ AndersonTorres SuperSandro2000 ];
Copy link
Member

@AndersonTorres AndersonTorres Aug 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What am I doing here??

Copy link
Member Author

@dotlambda dotlambda Aug 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You were a maintainer of the removed pkgs/tools/text/m2r.

Copy link
Member Author

@dotlambda dotlambda Aug 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndersonTorres Do you want me to remove your name?

@bobby285271 bobby285271 added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 13, 2022
jonasnick added a commit to jonasnick/nix-bitcoin that referenced this pull request Aug 14, 2022
@jonasnick
WIP: allow insecure package python3.10-mistune-0.8.4
9f8bf2b 
Wait until NixOS/nixpkgs#186272 is merged
@mofrim mofrim mentioned this pull request Aug 14, 2022
Merged
13 tasks
@dotlambda dotlambda merged commit eb642f8 into NixOS:master Aug 15, 2022
@dotlambda dotlambda deleted the mistune-single-version branch August 15, 2022 06:53
@smancill
Copy link
Contributor

smancill commented Aug 15, 2022 •
edited
Loading

Looks like this broke python3Packages.nbconvert (and thus, python3Packages.jupyter):

python3.10-nbconvert> ERROR: Could not find a version that satisfies the requirement mistune<2,>=0.8.1 (from nbconvert) (from versions: none)
python3.10-nbconvert> ERROR: No matching distribution found for mistune<2,>=0.8.1

This was referenced Aug 15, 2022
Merged
Merged
@prusnak prusnak mentioned this pull request Aug 15, 2022
Closed
smancill added a commit to smancill/nixpkgs that referenced this pull request Aug 17, 2022
@smancill
python310Packages.nbconvert: use mistune 2.x
8d05ef5 
mistune 0.8 was removed by NixOS#186272.
@vcunat
Copy link
Member

vcunat commented Aug 19, 2022

Did you have any plans for 22.05?

@risicle
Copy link
Contributor

risicle commented Aug 19, 2022

Completely forgot about that :/

@dotlambda
Copy link
Member Author

dotlambda commented Aug 19, 2022

It's only a small number of packages that are marked insecure on 22.05, I don't think we need to take action unless issues are opened. We can use mistune_2_0 where possible though.

@smancill
Copy link
Contributor

smancill commented Aug 19, 2022

jupyter is broken on 22.05:

https://discourse.nixos.org/t/jupyter-broken-in-22-05/21108/1

github-actions bot pushed a commit that referenced this pull request Aug 20, 2022
@smancill @github-actions
python310Packages.nbconvert: use mistune 2.x
3f71734 
mistune 0.8 was removed by #186272.

(cherry picked from commit 8d05ef5)
Ma27 pushed a commit to mayflower/nixpkgs that referenced this pull request Aug 22, 2022
@smancill @Ma27
python310Packages.nbconvert: use mistune 2.x
898d644 
mistune 0.8 was removed by NixOS#186272.

(cherry picked from commit 8d05ef5)
Ma27 pushed a commit to mayflower/nixpkgs that referenced this pull request Aug 22, 2022
@smancill @Ma27
python310Packages.nbconvert: use mistune 2.x
4526204 
mistune 0.8 was removed by NixOS#186272.

(cherry picked from commit 8d05ef5)
(cherry picked from commit 898d644)
jsoo1 pushed a commit to awakesecurity/nixpkgs that referenced this pull request Aug 8, 2023
@smancill @jsoo1
python310Packages.nbconvert: use mistune 2.x
15048b7 
mistune 0.8 was removed by NixOS#186272.
jsoo1 pushed a commit to awakesecurity/nixpkgs that referenced this pull request Sep 7, 2023
@smancill @jsoo1
python310Packages.nbconvert: use mistune 2.x
fee2dfb 
mistune 0.8 was removed by NixOS#186272.
awake-bot pushed a commit to awakesecurity/nixpkgs that referenced this pull request Oct 20, 2023
@smancill @jsoo1
python310Packages.nbconvert: use mistune 2.x
fabfdb2 
mistune 0.8 was removed by NixOS#186272.
jsoo1 pushed a commit to awakesecurity/nixpkgs that referenced this pull request Dec 14, 2023
@smancill @jsoo1
python310Packages.nbconvert: use mistune 2.x
5d5f2d0 
mistune 0.8 was removed by NixOS#186272.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@prusnak prusnak Awaiting requested review from prusnak

@risicle risicle Awaiting requested review from risicle

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@legendofmiracles legendofmiracles Awaiting requested review from legendofmiracles

@marsam marsam Awaiting requested review from marsam

+1 more reviewer

@AndersonTorres AndersonTorres AndersonTorres requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python Python is a high-level, general-purpose programming language. 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@dotlambda @smancill @vcunat @risicle @AndersonTorres @SuperSandro2000 @bobby285271