[22.05] python3Packages.nbconvert: use mistune 2.x#187839
Closed
Ma27 wants to merge 4 commits intoNixOS:release-22.05from
Closed
[22.05] python3Packages.nbconvert: use mistune 2.x#187839Ma27 wants to merge 4 commits intoNixOS:release-22.05from
Ma27 wants to merge 4 commits intoNixOS:release-22.05from
Conversation
mistune 0.8 was removed by NixOS#186272. (cherry picked from commit 8d05ef5) (cherry picked from commit 898d644)
This change is also needed on stable because `mistune` points to `mistune_0_8` rather than `mistune_2_0`. (cherry picked from commit 44e9fe8)
FRidh
suggested changes
Aug 22, 2022
Member
FRidh
left a comment
There was a problem hiding this comment.
This will result in different versions of mistune used within the python packages set. That's not acceptable.
Not a big loss because these would evaluate anyways before.
Member
Author
|
Can be closed now considering #188031. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Backport of #187151, #186804 to get opsdroid on 22.05 buildable again.
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes