Skip to content

[22.05] python3Packages.nbconvert: use mistune 2.x#187839

Closed
Ma27 wants to merge 4 commits intoNixOS:release-22.05from
mayflower:backport-nbconvert-fixes
Closed

[22.05] python3Packages.nbconvert: use mistune 2.x#187839
Ma27 wants to merge 4 commits intoNixOS:release-22.05from
mayflower:backport-nbconvert-fixes

Conversation

@Ma27
Copy link
Member

@Ma27 Ma27 commented Aug 22, 2022

Description of changes

Backport of #187151, #186804 to get opsdroid on 22.05 buildable again.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

smancill and others added 3 commits August 22, 2022 11:05
mistune 0.8 was removed by NixOS#186272.

(cherry picked from commit 8d05ef5)
(cherry picked from commit 898d644)
(cherry picked from commit 2ee664d)
(cherry picked from commit c5c7857)
This change is also needed on stable because `mistune` points to
`mistune_0_8` rather than `mistune_2_0`.

(cherry picked from commit 44e9fe8)
@Ma27 Ma27 added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Aug 22, 2022
@Ma27 Ma27 requested a review from globin August 22, 2022 09:17
@Ma27 Ma27 requested review from FRidh and jonringer as code owners August 22, 2022 09:17
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 22, 2022
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Aug 22, 2022
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will result in different versions of mistune used within the python packages set. That's not acceptable.

#187550 (comment)

Not a big loss because these would evaluate anyways before.
@Ma27
Copy link
Member Author

Ma27 commented Aug 23, 2022

Can be closed now considering #188031.

@Ma27 Ma27 closed this Aug 23, 2022
@Ma27 Ma27 deleted the backport-nbconvert-fixes branch August 23, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants