Skip to content

manim: 0.16.0 -> 0.16.0.post0#182781

Merged
ryantm merged 1 commit intoNixOS:masterfrom
r-ryantm:auto-update/manim
Aug 25, 2022
Merged

manim: 0.16.0 -> 0.16.0.post0#182781
ryantm merged 1 commit intoNixOS:masterfrom
r-ryantm:auto-update/manim

Conversation

@r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for manim is: "Animation engine for explanatory math videos - Community version"

meta.homepage for manim is: "https://github.com/ManimCommunity/manim"

meta.changelog for manim is: ""

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact
Checks done (click to expand)
  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 0.16.0.post0 with grep in /nix/store/ybjw8wlc4q3qw9ka0zbw9s7vl1m7gfkh-manim-0.16.0.post0
  • found 0.16.0.post0 in filename of file in /nix/store/ybjw8wlc4q3qw9ka0zbw9s7vl1m7gfkh-manim-0.16.0.post0

Rebuild report (if merged into master) (click to expand)
2 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 x86_64-darwin rebuild(s)


First fifty rebuilds by attrpath
manim
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/ybjw8wlc4q3qw9ka0zbw9s7vl1m7gfkh-manim-0.16.0.post0 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A manim https://github.com/r-ryantm/nixpkgs/archive/02c2eda2636e487d20e2a2c34b3744697d2f8263.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/ybjw8wlc4q3qw9ka0zbw9s7vl1m7gfkh-manim-0.16.0.post0
ls -la /nix/store/ybjw8wlc4q3qw9ka0zbw9s7vl1m7gfkh-manim-0.16.0.post0/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

1 package built:
  • manim

Maintainer pings

cc @friedelino for testing.

@ofborg ofborg bot requested a review from mofrim July 25, 2022 05:27
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jul 25, 2022
Copy link
Contributor

@mofrim mofrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

built failing due to failing built of python3*Packages.nbclassic. need to fix this first @elohmeier

Result of nixpkgs-review pr 182781 run on x86_64-linux 1

1 package failed to build:
  • manim
$ nix --experimental-features nix-command build --no-link --keep-going --option build-use-sandbox relaxed -f /home/frido/.cache/nixpkgs-review/pr-182781/build.nix
error: builder for '/nix/store/zwyaxa6yywj1yh6v0511gfcqn7abphvc-python3.10-nbclassic-0.4.3.drv' failed with exit code 1;
       last 10 log lines:
       > running bdist_wheel
       > running jsversion
       > running js
       > running jsdeps
       > npm unavailable
       > > bower install --allow-root --config.interactive=false
       > Failed to run bower: [Errno 2] No such file or directory: 'bower'
       > You can install js dependencies with `npm install`
       > rebuilding js and css failed. The following required files are missing: ['nbclassic/static/components', 'nbclassic/static/notebook/js/main.min.js', 'nbclassic/static/tree/js/main.min.js', 'nbclassic/static/edit/js/main.min.js', 'nbclassic/static/terminal/js/main.min.js', 'nbclassic/static/auth/js/main.min.js', 'nbclassic/static/style/ipython.min.css', 'nbclassic/static/style/style.min.css']
       > error: [Errno 2] No such file or directory: 'bower'
       For full logs, run 'nix log /nix/store/zwyaxa6yywj1yh6v0511gfcqn7abphvc-python3.10-nbclassic-0.4.3.drv'.
error: 1 dependencies of derivation '/nix/store/8r60zb3fpglm1lv05q1x203v0jbv8m6n-python3.10-jupyterlab-3.4.4.drv' failed to build
error: 1 dependencies of derivation '/nix/store/vs96bkvnplq0sqpcw4vlka02d8nxqkw8-manim-0.16.0.post0.drv' failed to build
error: 1 dependencies of derivation '/nix/store/msp9hrbwd65qgfs6wrwbf2sh050yzb8g-review-shell.drv' failed to build

@mofrim
Copy link
Contributor

mofrim commented Aug 18, 2022

nbclassic issue solved with #186703. if #187315 gets merged manim will also build again.

@mofrim
Copy link
Contributor

mofrim commented Aug 18, 2022

Current nixpkgs-review:

Result of nixpkgs-review pr 182781 run on x86_64-linux 1

1 package failed to build:
  • manim

Problems are: 2 failing tests->

error: builder for '/nix/store/l15gwx0n1fd2qqyy94pcgxmsdmwyhgbh-manim-0.16.0.post0.drv' failed with exit code 1;
       last 10 log lines:
       > E           Max absolute difference: 255
       > E           Max relative difference: 2.42857143
       >
       > manim/utils/testing/_frames_testers.py:42: AssertionError
       > =========================== short test summary info ============================
       > FAILED tests/test_graphical_units/test_mobjects.py::test_PointCloudDot
       > FAILED tests/test_graphical_units/test_threed.py::test_Torus
       > == 2 failed, 541 passed, 1 skipped, 5 xfailed, 1 xpassed in 304.38s (0:05:04) ==
       > Manim Community v0.16.0.post0
       >
       For full logs, run 'nix log /nix/store/l15gwx0n1fd2qqyy94pcgxmsdmwyhgbh-manim-0.16.0.post0.drv'.
error: 1 dependencies of derivation '/nix/store/cds0szbb6wkwn5w3j01abq06p1j7kysp-review-shell.drv' failed to build

which will be ignored after #187315 is merged.

@smancill smancill requested review from mofrim and removed request for mofrim August 18, 2022 21:56
Copy link
Contributor

@mofrim mofrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream authors forgot about adding one extra version requirement which should have been included in 0.16.0 release. That's why 0.16.0.post0 release has been added. Also with #187315 being merged build will succeed again.

@bobby285271 bobby285271 added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Aug 19, 2022
@smancill
Copy link
Contributor

@friedelino could you run nixpkgs-review again to confirm that it works?

@ryantm
Copy link
Member

ryantm commented Aug 25, 2022

Result of nixpkgs-review pr 182781 run on x86_64-linux 1

1 package built:
  • manim

@ryantm ryantm merged commit 10262e7 into NixOS:master Aug 25, 2022
@r-ryantm r-ryantm deleted the auto-update/manim branch August 25, 2022 04:43
@mofrim
Copy link
Contributor

mofrim commented Aug 25, 2022

The same result for me :)

Result of nixpkgs-review pr 182781 run on x86_64-linux 1

1 package built:
  • manim

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants