Skip to content

python310Packages.bitstring: fix unit tests#187531

Merged
SuperSandro2000 merged 1 commit intoNixOS:staging-nextfrom
tjni:fix-bitstring
Aug 21, 2022
Merged

python310Packages.bitstring: fix unit tests#187531
SuperSandro2000 merged 1 commit intoNixOS:staging-nextfrom
tjni:fix-bitstring

Conversation

@tjni
Copy link
Contributor

@tjni tjni commented Aug 19, 2022

The unit tests are broken on staging by the new unittest hook, because this project did not run its tests using unittest from project root. For now, I've submitted a patch upstream and pulled it in here so that the build is unblocked.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 22.11 Release Notes (or backporting 22.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
    • (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes
  • Fits CONTRIBUTING.md.

@tjni tjni requested review from FRidh and jonringer as code owners August 19, 2022 23:13
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Aug 19, 2022
@tjni tjni mentioned this pull request Aug 19, 2022
@ofborg ofborg bot requested a review from bjornfor August 19, 2022 23:22
@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Aug 19, 2022
The unit tests are broken on staging by the new unittest hook, because
this project did not run its tests using `unittest` from project root.
For now, I've submitted a patch upstream and pulled it in here so that
the build is unblocked.
@ofborg ofborg bot requested a review from bjornfor August 20, 2022 08:21
@bobby285271 bobby285271 added the 12.approvals: 1 This PR was reviewed and approved by one person. label Aug 21, 2022
@SuperSandro2000 SuperSandro2000 merged commit 9fdef95 into NixOS:staging-next Aug 21, 2022
@tjni tjni deleted the fix-bitstring branch August 21, 2022 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants