prometheus-xmpp-alerts: Fix build by removing unittestCheckHook argument#191631
Merged
fpletz merged 1 commit intoNixOS:masterfrom Sep 18, 2022
Merged
prometheus-xmpp-alerts: Fix build by removing unittestCheckHook argument#191631fpletz merged 1 commit intoNixOS:masterfrom
fpletz merged 1 commit intoNixOS:masterfrom
Conversation
In NixOS#185430 the `unittestCheckHook` argument was introduced, causing the derivation to fail building since the `unittestCheckHook` is not passed. However the original PR already used the `unittestCheckHook` from `python3Packages`.
ofborg
bot
added
10.rebuild-darwin: 1-10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #185430 the
unittestCheckHookargument was introduced, causing the derivation to fail building since theunittestCheckHookis not passed. However the original PR already used theunittestCheckHookfrompython3Packages.Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes