doc/languages-frameworks/python: Reword section to make commit rules a bit clearer#339643
Conversation
There was a problem hiding this comment.
IIRC, this is out of date and ofborg will build both package sets if you use (not sure if this was ever true). Therefore this advice is actually counterproductive.python3Packages
Disclaimer: I have not verified this recently.
There was a problem hiding this comment.
I believe that #165994 fixed this, but maybe it regressed since or something.
There was a problem hiding this comment.
python3Packages does not work on ofborg, I (wearily) nit about it for that reason.
There was a problem hiding this comment.
Also just to encourage good practices from people who are reading too quickly, we should either specify python312Packages specifically or say python3xxPackages to be more general IMO.
There was a problem hiding this comment.
I swear it worked at one point. Maybe I’m just imagining things or maybe it broke again. I’m not the only person who remembered it working since someone else said to me recently that it had been fixed at some point. :(
There was a problem hiding this comment.
I have been checking python libraries for over a year and have never had it work. Maybe they missed that someone ran it manually.
People don't read much documentation, but they often ask reviewers to show them documentation.
It needs to be clearly stated to avoid unnecessary discussion.
There was a problem hiding this comment.
I think python3{11,12}Packages.… should work, right? Maybe we should prefer that to check both supported versions. (I don’t suppose we can get away with python3*Packages?)
There was a problem hiding this comment.
Personally, I don't want to complicate it because that can be checked by nixpkgs-review.
In my experience, just checking one version is usually enough to catch build failures on aarch64-linux or darwin that are often overlooked.
eclairevoyant
left a comment
There was a problem hiding this comment.
I think the changes read naturally and it's certainly more explicit. Thank you for the PR!
956d597 to
00a43d7
Compare
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4801 |
|
Successfully created backport PR for |
Description of changes
See the minor confusion at #339136 (comment)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.