all-packages.nix: python3Packages recurse into pythonXXPackages#166029
Closed
Artturin wants to merge 3 commits intoNixOS:masterfrom
Closed
all-packages.nix: python3Packages recurse into pythonXXPackages#166029Artturin wants to merge 3 commits intoNixOS:masterfrom
Artturin wants to merge 3 commits intoNixOS:masterfrom
Conversation
should help with ofborg not building commits which have python3Packages instead of python39Packages see NixOS/ofborg#577
github-actions
bot
added
the
6.topic: python
ofborg
bot
added
8.has: package (new)
ofborg
bot
added
the
8.has: clean-up
FRidh
reviewed
Mar 29, 2022
| python37Packages = python37.pkgs; | ||
| python38Packages = python38.pkgs; | ||
| python39Packages = recurseIntoAttrs python39.pkgs; | ||
| python39Packages = python39.pkgs; |
Member
There was a problem hiding this comment.
I think we can just keep this one as well
stale
bot
added
the
2.status: stale
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
should help with ofborg not building
commits which have python3Packages instead of
python39Packages
see NixOS/ofborg#577
Follow up to #165994
since it didn't work
Testing the eval perf impact of recursing only python3Packages
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixos/doc/manual/md-to-db.shto update generated release notes