fix(public): repair heading hierarchy on terms, privacy, and Drishti privacy pages - #74
Conversation
…privacy pages The three trust pages still jumped from the H1 straight to H3 content-card headings, leaving the document outline without an H2 section level. The card titles are now semantic H2s; the shared .info-card :is(h2, h3) rule already keeps the former card scale and margin, so visible styling is unchanged. The heading-hierarchy regression test now covers the three routes too, so CI fails if any of them skips a heading level again. verify: node scripts/test-public-heading-hierarchy.mjs (62 checks, 0 failures; fails when a card heading is reverted to H3), npm run check exit 0, git diff --check clean
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
Warning Review limit reached
Next review available in: 26 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Comment |
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
The fleet keeps dispatching the same finding to multiple lanes, producing duplicate same-fix PR pairs: #36/#44 and #55/#56 are byte-identical or near-identical patches of the operator export --help fix, #39/#49 the offername article fix, #40/#52 the recording exporter --help fix, plus #38/#48/#51, #30/#61/#72, #45/#64, #42/#60, #43/#54 and #46/#74. Add a PR Duplicate Guard: - scripts/check-pr-duplicates.mjs compares a PR's diff against every other open PR (shared changed-file coverage >= 0.8 and patch similarity >= 0.5). Calibrated on all 79 open PRs on 2026-08-11: every pair above the thresholds was a genuine duplicate-cluster member, zero false positives. - .github/workflows/pr-duplicate-guard.yml runs it on every PR event and posts one marker comment naming the duplicate(s) and the canonical PR; the check fails loudly when a duplicate is found. Informational, not required. - scripts/test-pr-duplicates.mjs covers parsing, similarity, detection, and comment upsert with an injected API; wired into npm ci and npm test.
fix(public): verify trust-page H1->H2x3 outline on the live deploy (PR #74)
…ierarchy-reverify-20260821 docs(lane1): reverify trust-page heading-hierarchy item — fixed in PR #74 and now verified live
What
The three trust pages still jumped from the H1 straight to H3 content-card headings, leaving the document outline without an H2 section level:
/terms/->public/terms/index.html/privacy/->public/privacy/index.html/drishti/privacy/->public/drishti/privacy/index.htmlThe three
.info-cardcard titles on each page are now semantic H2s. The shared.info-card :is(h2, h3)CSS rule already keeps the former card scale and margin, so visible styling is unchanged.Regression guard
scripts/test-public-heading-hierarchy.mjsnow covers the three routes (62 checks, up from 44). The test fails if any card heading regresses to H3 (verified locally).Verify
node scripts/test-public-heading-hierarchy.mjs-> 62 checks, 0 failuresnpm run check-> exit 0 (all suites green)git diff --check-> clean