fix(public): repair heading hierarchy on terms, privacy, and Drishti privacy pages by nish3451 · Pull Request #46 · Nishfleet/tinystudio-in

nish3451 · 2026-08-10T16:07:11Z

What

The three trust pages /terms/, /privacy/, and /drishti/privacy/ still rendered H1 → H3 → H3 → H3 before the footer H2/H3 — a skipped heading level that breaks the document outline for assistive technology and is the same class already repaired on six other public pages (PRs #18/#20/#23).

The three content-card titles are now semantic <h2>s. The shared .info-card :is(h2, h3) rule (added in #23) already preserves the former card scale and margin, so no CSS change is needed.

Why now

The improvement-loop backlog item for these three routes is open and annotated unowned by an open PR as recently as 2026-08-10. This lane's live/source walk re-confirmed the skip in source on origin/main (a0d1de5). When the blocked deploy path catches up, these pages would otherwise ship the outline defect.

Verification

node scripts/test-public-heading-hierarchy.mjs: 62 checks, 0 failures (regression extended from 6 to 9 pages; previously 44 checks)
Negative check: reverting one card heading to <h3> makes the test fail with the exact H1 -> H3 skip class
npm run check and npm run ci: exit 0, full suite green (service engine + all public regressions)
Visual: before/after renders byte-identical (sharp pixel diff, 0 differing pixels) at 1366x900 and 390x844 on all three pages; zero console errors, zero horizontal overflow
git diff --check clean

Scope

Only the four files above. Copy, styling, links, and routes unchanged. Homepage (covered by open PR #38) and the other six audited pages untouched.

Summary by CodeRabbit

Accessibility
- Improved heading hierarchy across privacy and terms pages for clearer navigation and better screen-reader support.
Tests
- Expanded heading-structure checks to cover public terms, privacy, privacy choices, and Drishti privacy pages.

…privacy pages The three trust pages still jumped from the H1 straight to H3 content-card headings, leaving the document outline without an H2 section level. The card titles are now semantic H2s; the shared .info-card :is(h2, h3) rule already keeps the former card scale and margin, so visible styling is unchanged (pixel-verified at 1366x900 and 390x844). The heading-hierarchy regression now covers the three routes too, so CI fails if any of them skips a heading level again (62 checks, previously 44; verified to fail when a card heading is reverted to H3).

greptile-apps

nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

coderabbitai · 2026-08-10T16:07:34Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ae796920-af15-49cc-991a-85772722e778

📥 Commits

Reviewing files that changed from the base of the PR and between a0d1de5 and ab21d40.

📒 Files selected for processing (4)

public/drishti/privacy/index.html
public/privacy/index.html
public/terms/index.html
scripts/test-public-heading-hierarchy.mjs

📝 Walkthrough

Walkthrough

The terms and privacy pages now use <h2> for card headings. The public heading-hierarchy test now includes these pages and the Drishti privacy page.

Changes

Public heading hierarchy

Layer / File(s)	Summary
Update public card headings `public/terms/index.html`, `public/privacy/index.html`, `public/drishti/privacy/index.html`	The nine card headings changed from `<h3>` to `<h2>`.
Expand heading validation coverage `scripts/test-public-heading-hierarchy.mjs`	The heading-hierarchy test now includes the terms, privacy, and Drishti privacy pages. The comment identifies the homepage as separately validated.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

nish3451/tinystudio-in#18: Both changes update the heading-hierarchy test and public pages.
nish3451/tinystudio-in#20: Both changes promote public card headings from <h3> to <h2> and extend validation.
nish3451/tinystudio-in#23: Both changes update public card headings and heading-hierarchy coverage.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the heading hierarchy fixes on the three affected public pages.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

Create stacked PR
Commit on current branch

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/lane1-self-directed-cycle-20260810

_{Comment @coderabbitai help to get the list of available commands.}

greptile-apps

nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

chatgpt-codex-connector · 2026-08-10T21:43:15Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

greptile-apps

nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

The fleet keeps dispatching the same finding to multiple lanes, producing duplicate same-fix PR pairs: #36/#44 and #55/#56 are byte-identical or near-identical patches of the operator export --help fix, #39/#49 the offername article fix, #40/#52 the recording exporter --help fix, plus #38/#48/#51, #30/#61/#72, #45/#64, #42/#60, #43/#54 and #46/#74. Add a PR Duplicate Guard: - scripts/check-pr-duplicates.mjs compares a PR's diff against every other open PR (shared changed-file coverage >= 0.8 and patch similarity >= 0.5). Calibrated on all 79 open PRs on 2026-08-11: every pair above the thresholds was a genuine duplicate-cluster member, zero false positives. - .github/workflows/pr-duplicate-guard.yml runs it on every PR event and posts one marker comment naming the duplicate(s) and the canonical PR; the check fails loudly when a duplicate is found. Informational, not required. - scripts/test-pr-duplicates.mjs covers parsing, similarity, detection, and comment upsert with an injected API; wired into npm ci and npm test.

greptile-apps

nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f82e94e3b2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-08-11T10:52:44Z

+// (public/index.html) is covered separately in section D below, including the
+// managed-service section's H2 -> H3 outline.


Add the homepage check promised by this comment

There is no section D in this script—it ends after section C—and public/index.html is absent from AFFECTED_PAGES. In the reviewed tree, the managed-service section still contains an H2 followed directly by an H4 (public/index.html lines 287 and 298), while this test reports success. The new comment therefore claims regression coverage that does not exist; add the explicit homepage check and repair the hierarchy, or remove the claim.

Useful? React with 👍 / 👎.

greptile-apps

nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.

nish3451 · 2026-08-19T08:49:20Z

Closing as landed — this PR's entire diff is one comment, and main already carries that exact comment.

The change here rewrites the AFFECTED_PAGES comment in scripts/test-public-heading-hierarchy.mjs to mention that the homepage is covered separately in section D. main now reads:

// The exact public pages covered by the card-heading finding. The homepage
// (public/index.html) is covered separately in section D below, including
// the managed-service section's H2 -> H3 outline.

which is word-for-word what this branch adds, differing only in where the line wraps. That line-wrap difference is the whole remaining conflict. There is no code change left to land.

greptile-apps Bot reviewed Aug 10, 2026

View reviewed changes

coderabbitai Bot mentioned this pull request Aug 10, 2026

fix(public): repair homepage managed-service heading hierarchy (H2->H3) #48

Closed

Merge branch 'main' into fix/lane1-self-directed-cycle-20260810

13c42bf

greptile-apps Bot reviewed Aug 10, 2026

View reviewed changes

Merge branch 'main' into fix/lane1-self-directed-cycle-20260810

c2ad1b9

greptile-apps Bot reviewed Aug 10, 2026

View reviewed changes

coderabbitai Bot mentioned this pull request Aug 11, 2026

fix(public): guard the live site against skipped heading levels (closes Drishti support and Privacy Choices finding) #76

Closed

nish3451 mentioned this pull request Aug 11, 2026

fix(ops): guard against duplicate same-fix pull requests #80

Merged

Merge remote-tracking branch 'origin/main' into tmp-merge-46

f82e94e

greptile-apps Bot reviewed Aug 11, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Aug 11, 2026

View reviewed changes

Merge remote-tracking branch 'origin/main' into tmp2-46

064edac

greptile-apps Bot reviewed Aug 11, 2026

View reviewed changes

coderabbitai Bot mentioned this pull request Aug 11, 2026

fix(public): verify trust-page H1->H2x3 outline on the live deploy (PR #74) #87

Merged

nish3451 closed this Aug 19, 2026

Navigation Menu

Uh oh!

fix(public): repair heading hierarchy on terms, privacy, and Drishti privacy pages - #46

fix(public): repair heading hierarchy on terms, privacy, and Drishti privacy pages#46
nish3451 wants to merge 5 commits into
mainfrom
fix/lane1-self-directed-cycle-20260810

nish3451 commented Aug 10, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

greptile-apps Bot left a comment

Uh oh!

coderabbitai Bot commented Aug 10, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

greptile-apps Bot left a comment

Uh oh!

chatgpt-codex-connector Bot commented Aug 10, 2026

Uh oh!

greptile-apps Bot left a comment

Uh oh!

greptile-apps Bot left a comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Aug 11, 2026

Uh oh!

greptile-apps Bot left a comment

Uh oh!

nish3451 commented Aug 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

		// (public/index.html) is covered separately in section D below, including the
		// managed-service section's H2 -> H3 outline.

Uh oh!

Conversation

nish3451 commented Aug 10, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Why now

Verification

Scope

Summary by CodeRabbit

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot commented Aug 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot commented Aug 10, 2026

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Aug 11, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

nish3451 commented Aug 19, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

nish3451 commented Aug 10, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Aug 10, 2026 •

edited

Loading