fix(public): replace submission-prep copy on app privacy page H1s - #30
fix(public): replace submission-prep copy on app privacy page H1s#30nish3451 wants to merge 2 commits into
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe Drishti and Promptly privacy pages now describe current app behavior, data handling, advertising practices, user choices, and conditions for updating privacy disclosures when external services are added. ChangesPrivacy page updates
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 32c1442259
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <div> | ||
| <p class="eyebrow">Drishti privacy</p> | ||
| <h1>Drishti’s privacy page is already in place before launch.</h1> | ||
| <h1>Drishti privacy for pauses, streaks, and practice data.</h1> |
There was a problem hiding this comment.
For users who create streaks or complete pauses, this heading now says the policy covers their “practice data,” but the page only explains support-email information and never states whether pause, streak, ritual, or focus records are stored locally, transmitted, retained, or deletable. Either document that handling and the corresponding choices or avoid claiming this policy covers practice data.
Useful? React with 👍 / 👎.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@public/drishti/privacy/index.html`:
- Around line 86-90: Update the privacy policy content in the page hero and
related coverage claims to either describe Drishti’s pauses, streaks, and
practice data—including what is created, whether it remains on-device or is
transmitted, its purpose, and retention/deletion rules—or remove those
categories from the claims. Keep the existing support-message, screenshot, and
device-detail descriptions unchanged.
- Around line 110-115: Update the privacy content near the “Advertising and
tracking” heading to state directly that Drishti does not use third-party
advertising or cross-app tracking. Separately state that the Drishti website has
no public sign-in system and does not process payments, without implying that
the same applies to in-app accounts or payments.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: a93a0c5c-3f93-4f07-8146-54bee216d4fe
📒 Files selected for processing (2)
public/drishti/privacy/index.htmlpublic/promptly/privacy/index.html
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
The Promptly and Drishti privacy page H1s still spoke to the internal
App Store submission process ("already public ahead of release",
"already in place before launch"), and the hero lead, release-scope
aside, and note copy carried the same submission-prep framing that was
removed from the product and support pages in e71a689.
Rewrite those passages as visitor-facing copy that describes what each
privacy page covers and the product itself, without referencing the
submission process. Heading levels, links, meta tags, and JSON-LD are
unchanged.
dcb5215 to
5bf5aa1
Compare
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
Remove the pauses, streaks, and practice data categories from the Drishti privacy H1, lead, and coverage list, since the policy does not describe those categories' handling. State directly that the Drishti website has no public sign-in or payments, separate from in-app accounts or payments, which this page does not describe. Addresses CodeRabbit comments on PR #30.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
nish3451 has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
|
Follow-up commit 9e17c1a addresses the two CodeRabbit comments from the earlier review:
The branch was also rebased onto current origin/main. Public-site checks (heading hierarchy, structured data, link targets, brand disambiguation, conversion signal, soft-404, social preview) all pass locally. |
|
Verification pass (lane 1, 2026-08-11): the packet item — "App privacy page H1s still speak to App Store submission" — is covered by this PR.
No changes required; item satisfied by this branch. |
The fleet keeps dispatching the same finding to multiple lanes, producing duplicate same-fix PR pairs: #36/#44 and #55/#56 are byte-identical or near-identical patches of the operator export --help fix, #39/#49 the offername article fix, #40/#52 the recording exporter --help fix, plus #38/#48/#51, #30/#61/#72, #45/#64, #42/#60, #43/#54 and #46/#74. Add a PR Duplicate Guard: - scripts/check-pr-duplicates.mjs compares a PR's diff against every other open PR (shared changed-file coverage >= 0.8 and patch similarity >= 0.5). Calibrated on all 79 open PRs on 2026-08-11: every pair above the thresholds was a genuine duplicate-cluster member, zero false positives. - .github/workflows/pr-duplicate-guard.yml runs it on every PR event and posts one marker comment naming the duplicate(s) and the canonical PR; the check fails loudly when a duplicate is found. Informational, not required. - scripts/test-pr-duplicates.mjs covers parsing, similarity, detection, and comment upsert with an injected API; wired into npm ci and npm test.
1 participant
What
The app privacy page H1s still spoke to the internal App Store submission process:
These were missed by the earlier pass in #28 (e71a689), which replaced internal editorial and submission-prep copy on the four app product/support pages.
Changes
Rewrote the submission-prep passages on
public/promptly/privacy/index.htmlandpublic/drishti/privacy/index.htmlas visitor-facing copy:Heading levels, links, meta tags, chips, and JSON-LD are unchanged.
Validation
node scripts/test-public-heading-hierarchy.mjs— 44 checks, 0 failuresnode scripts/test-public-link-targets.mjs— 74 checks, 0 failuresnode scripts/test-public-structured-data.mjs— 127 checks, 0 failuresnode scripts/test-public-social-preview.mjs— 137 checks, 0 failuresnode scripts/test-public-brand-disambiguation.mjs— 11 checks, 0 failuresnode scripts/test-public-conversion-signal.mjs— 126 checks, 0 failuresCloses the lane 1 item: app privacy page H1s still speaking to App Store submission.
Summary by CodeRabbit