fix(public): wrap Promptly hero heading at 320px without hiding overflow - #134
Conversation
The 3.4rem H1 left "professionals" unbreakable, so /promptly/ grew to 369px on a 320px viewport. Shared h1 overflow-wrap:anywhere after sibling pages stayed inside 320. Heading copy is unchanged.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
|
Warning Review limit reached
Next review available in: 32 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Free Run ID: 📒 Files selected for processing (2)
Note 🎁 Summarized by CodeRabbit FreeYour organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 420747eaf6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // try the next resolver | ||
| } | ||
| } | ||
| throw new Error("playwright is required to assert Promptly 320px heading overflow") |
There was a problem hiding this comment.
In any clean checkout without the author's unrelated 0509 workspace, npm ci installs only the locked dependencies, and neither package.json nor package-lock.json declares Playwright. Consequently every candidate fails and this unconditional throw aborts test-public-heading-hierarchy.mjs; I confirmed the script exits 1 in this repository. Since codex-ci.yml runs npm ci followed by npm run ci, and the deployment workflow similarly runs npm check, the required repository and deployment gates are now environment-dependent. Declare Playwright and install its Chromium binary as part of repository setup, or keep this browser check out of the mandatory suite.
AGENTS.md reference: AGENTS.md:L2-L3
Useful? React with 👍 / 👎.
…sing repo-checks has no Playwright, so the layout probe now skips there. The CSS wrap assertion still fails closed. Local runs keep the scrollWidth measurements.
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e143c5102
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!chromiumLauncher) { | ||
| console.log(" skip layout probe: playwright is not installed in this checkout") |
There was a problem hiding this comment.
The new missing-Playwright branch changes the prior hard failure into a silent pass, but repo-checks performs npm ci and neither package.json nor the lockfile declares Playwright, so every clean CI and deployment checkout skips all of the newly added viewport assertions. As a result, later CSS changes can restore the 320px overflow while the mandatory suite remains green; install Playwright/Chromium in the gate or move this probe to an environment that provides them.
Useful? React with 👍 / 👎.
…le with main after PRs #135/#104/#99/#112/#100/#105) The PR #130 branch had already been reconciled with origin/main through c617364 (PRs #131 + #133/#134/#132/#116). Since then origin/main moved to d4f3ef4 with six more merges (#135 #104 #99 #112 #100 #105). Pull them in so PR #130 can be reviewed against current main without weakening the capture/rollback/reverification implementation or the PR #131 fail-closed missing-secret gate. The merge resolved cleanly: - PR #130 capture/rollback logic (publish-public-site.mjs canonical_deployment, rollbackTo, restored identity re-verify, accept-again) is intact. - PR #130 test file (scripts/test-pages-release.mjs) is intact and wired into the npm ci/test scripts. - PR #131 fail-loud missing-secret workflow step in .github/workflows/deploy-public-site.yml is preserved byte-for-byte. - The new origin/main changes touch operator surfaces and the deploy bundle prep; none of them modify the publish-public-site.mjs rollback contract or the Pages token gate, so there were no conflict markers.
…0260823 test(live-gate): assert shared h1 overflow-wrap rule on deployed stylesheet (PR #134)
1 participant
Summary
Promptly's hero H1 uses
clamp(3.4rem, 7vw, 6.7rem), so the word "professionals" is ~354px inside a 272px box. At a 320px viewport the document grows to 369px and clips the heading.This adds
overflow-wrap: anywhereon the sharedh1rule after sibling product pages (/,/drishti/) were proven to stay inside 320. Heading copy is unchanged. The page is not clipped withoverflow-x: hidden.Proof
scripts/test-public-heading-hierarchy.mjsfailed pre-fix on the live numbers (documentElement.scrollWidth=369, heading354vs272) and passes after (320 <= 320, heading272 <= 272at both 320 and 390)./and/drishti/stay inside 320 after the shared wrap.Test plan
node scripts/test-public-heading-hierarchy.mjs— 81 checks, 0 failuresrepo-checks/promptly/HTTP 200 andscrollWidth <= clientWidthat 320 and 390Deploy note: the Pages token is still missing, so
deploy-public-site.ymlwill fail closed until Nish provisionsCLOUDFLARE_API_TOKEN.