Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nwb_schema_2.6.0 #1636

Merged
merged 15 commits into from
Jan 17, 2023
Merged

nwb_schema_2.6.0 #1636

merged 15 commits into from
Jan 17, 2023

Conversation

mavaylon1
Copy link
Collaborator

@mavaylon1 mavaylon1 commented Jan 17, 2023

Motivation

What was the reasoning behind this change? Please explain the changes briefly.
Update the NWB Schema repo to 2.6.0 for pynwb.

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

oruebel and others added 11 commits December 18, 2022 11:23
* Added NWBHDF5IO.nwb_version property and check for version on NWBHDF5IO.read
* Updated icephys tests to skip version check when writing non NWBFile container
* Add tests for NWB version check on read
* Add unit tests for NWBHDF5IO.nwb_version property
* Updated changelog

Co-authored-by: Ryan Ly <[email protected]>
Bumps [setuptools](https://github.com/pypa/setuptools) from 65.4.1 to 65.5.1.
- [Release notes](https://github.com/pypa/setuptools/releases)
- [Changelog](https://github.com/pypa/setuptools/blob/main/CHANGES.rst)
- [Commits](pypa/setuptools@v65.4.1...v65.5.1)

---
updated-dependencies:
- dependency-name: setuptools
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Create project_action.yml

* Update project_action.yml

* Update project_action.yml
* Create project_action.yml

* Update project_action.yml

* Update project_action.yml

* Update project_action.yml
* Show recommended usaege for hdf5plugin in tutorial

* Update docs/gallery/advanced_io/h5dataio.py

* Update docs/gallery/advanced_io/h5dataio.py

Co-authored-by: Heberto Mayorquin <[email protected]>

Co-authored-by: Ben Dichter <[email protected]>
Co-authored-by: Heberto Mayorquin <[email protected]>
* Update iterative write tutorial
* Update doc makefiles to clean up files created by the advanced io tutorial
* Fix #1514  Update parallel I/O tutorial to use H5DataIO instead of DataChunkIterator to setup data for parallel write
* Update changelog
* Fix flake8
* Fix broken external links
* Update make.bat
* Update CHANGELOG.md
* Update plot_iterative_write.py
* Update docs/gallery/advanced_io/plot_iterative_write.py

Co-authored-by: Ryan Ly <[email protected]>
@mavaylon1 mavaylon1 requested a review from rly January 17, 2023 15:53
@mavaylon1 mavaylon1 self-assigned this Jan 17, 2023
@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Merging #1636 (5229edb) into dev (2930095) will decrease coverage by 6.95%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #1636      +/-   ##
==========================================
- Coverage   91.31%   84.37%   -6.95%     
==========================================
  Files          25       25              
  Lines        2534     2534              
  Branches      481      481              
==========================================
- Hits         2314     2138     -176     
- Misses        139      311     +172     
- Partials       81       85       +4     
Flag Coverage Δ
integration ?
unit 84.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pynwb/validate.py 26.04% <0.00%> (-73.96%) ⬇️
src/pynwb/io/ophys.py 45.45% <0.00%> (-54.55%) ⬇️
src/pynwb/io/misc.py 38.46% <0.00%> (-43.59%) ⬇️
src/pynwb/io/image.py 66.66% <0.00%> (-33.34%) ⬇️
src/pynwb/io/base.py 56.79% <0.00%> (-27.17%) ⬇️
src/pynwb/io/core.py 61.53% <0.00%> (-17.31%) ⬇️
src/pynwb/io/file.py 82.38% <0.00%> (-11.95%) ⬇️
src/pynwb/__init__.py 74.00% <0.00%> (-4.67%) ⬇️
src/pynwb/misc.py 87.59% <0.00%> (-3.65%) ⬇️
src/pynwb/icephys.py 89.55% <0.00%> (-2.22%) ⬇️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rly rly changed the base branch from dev to schema_2.6.0 January 17, 2023 17:04
@mavaylon1 mavaylon1 merged commit e3381a0 into schema_2.6.0 Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants