Check nwb_version on read #1612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oruebel
added
category: enhancement
Codecov Report
@@ Coverage Diff @@
## dev #1612 +/- ##
==========================================
+ Coverage 91.25% 91.31% +0.06%
==========================================
Files 25 25
Lines 2515 2534 +19
Branches 477 481 +4
==========================================
+ Hits 2295 2314 +19
Misses 139 139
Partials 81 81
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
3 tasks
|
@rly this PR is ready for review |
rly
reviewed
Dec 17, 2022
rly
approved these changes
Dec 18, 2022
mavaylon1
added a commit
that referenced
this pull request
Jan 17, 2023
* Check nwb_version on read (#1612) * Added NWBHDF5IO.nwb_version property and check for version on NWBHDF5IO.read * Updated icephys tests to skip version check when writing non NWBFile container * Add tests for NWB version check on read * Add unit tests for NWBHDF5IO.nwb_version property * Updated changelog Co-authored-by: Ryan Ly <[email protected]> * Bump setuptools from 65.4.1 to 65.5.1 (#1614) Bumps [setuptools](https://github.com/pypa/setuptools) from 65.4.1 to 65.5.1. - [Release notes](https://github.com/pypa/setuptools/releases) - [Changelog](https://github.com/pypa/setuptools/blob/main/CHANGES.rst) - [Commits](pypa/setuptools@v65.4.1...v65.5.1) --- updated-dependencies: - dependency-name: setuptools dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * modify export.rst to have proper links to the NWBFile API docs (#1615) * Create project_action.yml (#1617) * Create project_action.yml * Update project_action.yml * Update project_action.yml * Update project_action.yml (#1620) * Update project_action.yml (#1623) * Project action (#1626) * Create project_action.yml * Update project_action.yml * Update project_action.yml * Update project_action.yml * Show recommended usaege for hdf5plugin in tutorial (#1630) * Show recommended usaege for hdf5plugin in tutorial * Update docs/gallery/advanced_io/h5dataio.py * Update docs/gallery/advanced_io/h5dataio.py Co-authored-by: Heberto Mayorquin <[email protected]> Co-authored-by: Ben Dichter <[email protected]> Co-authored-by: Heberto Mayorquin <[email protected]> * Update iterative write and parallel I/O tutorial (#1633) * Update iterative write tutorial * Update doc makefiles to clean up files created by the advanced io tutorial * Fix #1514 Update parallel I/O tutorial to use H5DataIO instead of DataChunkIterator to setup data for parallel write * Update changelog * Fix flake8 * Fix broken external links * Update make.bat * Update CHANGELOG.md * Update plot_iterative_write.py * Update docs/gallery/advanced_io/plot_iterative_write.py Co-authored-by: Ryan Ly <[email protected]> * Update project_action.yml (#1632) * nwb_schema_2.6.0 * Update CHANGELOG.md * remove Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Oliver Ruebel <[email protected]> Co-authored-by: Ryan Ly <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ben Dichter <[email protected]> Co-authored-by: Heberto Mayorquin <[email protected]>
3 tasks
6 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix #1609
This PR:
NWBHDF5IO.nwb_versionto check the nwb_version of an HDF5 file (i.e., before reading the file)NWBHDF5IO.readto raise a more informative error in case unsupported in case that unsupported file versions (i.e., NWB 1 files) are foundChecklist
flake8from the source directory.