Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show recommended usaege for hdf5plugin in tutorial #1630

Merged
merged 3 commits into from
Jan 8, 2023

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented Jan 8, 2023

Motivation

Fix #1629 to show recommended usage for hdf5plugin to set compression and compression_opts parameters for H5DataIO

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@oruebel oruebel marked this pull request as ready for review January 8, 2023 21:11
@codecov
Copy link

codecov bot commented Jan 8, 2023

Codecov Report

Merging #1630 (df3dd42) into dev (d6e9427) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1630   +/-   ##
=======================================
  Coverage   91.31%   91.31%           
=======================================
  Files          25       25           
  Lines        2534     2534           
  Branches      481      481           
=======================================
  Hits         2314     2314           
  Misses        139      139           
  Partials       81       81           
Flag Coverage Δ
integration 70.44% <ø> (ø)
unit 84.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@oruebel oruebel added this to the Next Release milestone Jan 8, 2023
@oruebel oruebel added category: enhancement improvements of code or code behavior topic: docs issues related to documentation priority: low alternative solution already working and/or relevant to only specific user(s) labels Jan 8, 2023
@oruebel oruebel requested a review from rly January 8, 2023 21:16
@bendichter bendichter merged commit f4bbbd6 into dev Jan 8, 2023
mavaylon1 added a commit that referenced this pull request Jan 17, 2023
* Check nwb_version on read (#1612)

* Added NWBHDF5IO.nwb_version property and check for version on NWBHDF5IO.read
* Updated icephys tests to skip version check when writing non NWBFile container
* Add tests for NWB version check on read
* Add unit tests for NWBHDF5IO.nwb_version property
* Updated changelog

Co-authored-by: Ryan Ly <[email protected]>

* Bump setuptools from 65.4.1 to 65.5.1 (#1614)

Bumps [setuptools](https://github.com/pypa/setuptools) from 65.4.1 to 65.5.1.
- [Release notes](https://github.com/pypa/setuptools/releases)
- [Changelog](https://github.com/pypa/setuptools/blob/main/CHANGES.rst)
- [Commits](pypa/setuptools@v65.4.1...v65.5.1)

---
updated-dependencies:
- dependency-name: setuptools
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* modify export.rst to have proper links to the NWBFile API docs (#1615)

* Create project_action.yml (#1617)

* Create project_action.yml

* Update project_action.yml

* Update project_action.yml

* Update project_action.yml (#1620)

* Update project_action.yml (#1623)

* Project action (#1626)

* Create project_action.yml

* Update project_action.yml

* Update project_action.yml

* Update project_action.yml

* Show recommended usaege for hdf5plugin in tutorial (#1630)

* Show recommended usaege for hdf5plugin in tutorial

* Update docs/gallery/advanced_io/h5dataio.py

* Update docs/gallery/advanced_io/h5dataio.py

Co-authored-by: Heberto Mayorquin <[email protected]>

Co-authored-by: Ben Dichter <[email protected]>
Co-authored-by: Heberto Mayorquin <[email protected]>

* Update iterative write and parallel I/O tutorial (#1633)

* Update iterative write tutorial
* Update doc makefiles to clean up files created by the advanced io tutorial
* Fix #1514  Update parallel I/O tutorial to use H5DataIO instead of DataChunkIterator to setup data for parallel write
* Update changelog
* Fix flake8
* Fix broken external links
* Update make.bat
* Update CHANGELOG.md
* Update plot_iterative_write.py
* Update docs/gallery/advanced_io/plot_iterative_write.py

Co-authored-by: Ryan Ly <[email protected]>

* Update project_action.yml (#1632)

* nwb_schema_2.6.0

* Update CHANGELOG.md

* remove

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Oliver Ruebel <[email protected]>
Co-authored-by: Ryan Ly <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Ben Dichter <[email protected]>
Co-authored-by: Heberto Mayorquin <[email protected]>
@rly rly deleted the docs/h5plugin_usage branch April 8, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: enhancement improvements of code or code behavior priority: low alternative solution already working and/or relevant to only specific user(s) topic: docs issues related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to pass dynamic filters compression options to H5DataIO?
3 participants